Use data payloads supplied by Server to download and upload blobs on Executor #1356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Executor Tested these changes with and without Server supplied data payloads in S3 and local FS blob store modes. They fully backward compatible. Both gRPC and SSE task stream modes support direct blob store downloads and uploads now.
eabatalov
force-pushed
the
eugene-task-input-s3-download-http
branch
from
fc48989 to
1ffdbc3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we process data payloads sent by Server on HTTP (SSE task stream) path.
gRPC path is already doing that.
For both gRPC and HTTP paths we also upload task outputs to blob store if task output blob store URI prefix is supplied by Server.
Both gRPC and SSE task stream modes support direct blob store downloads and uploads now.
Tested these changes with and without Server supplied data payloads in S3 and local FS blob store modes. They changes are fully backward compatible.