-
Notifications
You must be signed in to change notification settings - Fork 7
Lowering aten.native_group_norm.default
#556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Please fire a ticket. There should be no requirement to change from Tile to RM for PCC to pass. Sounds like a bug to me. |
that case is mentioned in #555 , or you prefer an individual issue@@? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM on the group norm parts added by this PR
grid_size_x = device.compute_with_storage_grid_size().x | ||
grid_size_y = device.compute_with_storage_grid_size().y | ||
shard_shape = N * H * W // grid_size_x, C // grid_size_y | ||
if shard_shape[0] == 0 or shard_shape[1] == 0: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe add a TODO to remind us the shard shape computation can be improved later
5a5790e
to
78b8945
Compare
78b8945
to
f59193f
Compare
f59193f
to
5822449
Compare
Ticket
#538
Problem description
Support the lowering of
aten.native_group_norm.default
I implement it accroding to test_group_norm.py on tt-metal
Originally I reference the
test_group_norm_with_block_sharded_v2_8x8_grid_tile_layout
part, but some cases accuracy failedAnd after I set the input_tensor layout as
TtnnRowMajorLayout
, its accuracy passAnd there still some case failed, I issued at #555
What's changed
aten.native_group_norm.default
btw, only
stable diffusion v2
&retinanet_resnet50_fpn_v2
use group_norm, so maybe this op's priority can lowerI'll merge #532 first and then this PR