Updated slices validations in the compiler #877
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayerofieiev-tt
approved these changes
Mar 31, 2025
jmalone-tt
approved these changes
Mar 31, 2025
|
PR title becomes a commit message, let’s make it clear that it’s about slices |
dgomezTT
changed the title
dgomezTT
force-pushed
the
dgomeztt/slide-validation
branch
from
cb43ae0 to
9cbbad7
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
dgomezTT
force-pushed
the
dgomeztt/slide-validation
branch
from
9cbbad7 to
61e95c4
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
dgomezTT
force-pushed
the
dgomeztt/slide-validation
branch
from
61e95c4 to
22774f4
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
dgomezTT
force-pushed
the
dgomeztt/slide-validation
branch
from
22774f4 to
fc8e875
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
dgomezTT
force-pushed
the
dgomeztt/slide-validation
branch
from
fc8e875 to
164d179
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
dgomezTT
force-pushed
the
dgomeztt/slide-validation
branch
from
164d179 to
cd6e059
Compare
…piler already fills with 1 when the array is empty, we can assume that will be always equals or bigger than 1
dgomezTT
force-pushed
the
dgomeztt/slide-validation
branch
from
cd6e059 to
909a98a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated step validations, now different than 1 is a valid scenario. Since the compiler already fills with 1 when the array is empty, we can assume that will be always equals or bigger than 1
Ticket
Link to Github Issue
Problem description
Metal updated it's code, allowing slices bigger than 1
What's changed
Updated the compiler code to be compatible with this new validation