optimizer details (draft) #2754
Conversation
einnesTT
requested review from
acolicTT,
dgolubovicTT,
nvukobratTT and
pilkicTT
as code owners
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2754 +/- ##
==========================================
+ Coverage 45.45% 50.36% +4.91%
==========================================
Files 57 171 +114
Lines 8261 13042 +4781
==========================================
+ Hits 3755 6569 +2814
- Misses 4506 6473 +1967 ☔ View full report in Codecov by Sentry. |
| compiler_cfg.mlir_config = ( | ||
| MLIRConfig() | ||
| .set_enable_optimizer(True) | ||
| .set_enable_fusing(True) |
There was a problem hiding this comment.
This is on by default and is no longer needed.
| ## Prerequisites | ||
|
|
||
| To use the AI compiler optimizer with TT-Forge-FE, you need the following: | ||
| * TT-Forge set up, using the [Getting Started with Building TT-Forge-FE From Source](getting_started_build_from_source.md) instructions |
There was a problem hiding this comment.
I don't think a build from source is needed just for setting this config.
| .set_enable_optimizer(True) | ||
| .set_enable_fusing(True) | ||
| .set_enable_fusing_conv2d_with_multiply_pattern(True) | ||
| .set_enable_memory_layout_analysis(False) |
There was a problem hiding this comment.
Consider using ANCHOR links.
Example:
doc: https://github.com/tenstorrent/tt-mlir/blob/05c95b344a6f8622b357c6f7208297acf5dc447f/docs/src/adding-an-op.md?plain=1#L272
code: https://github.com/tenstorrent/tt-mlir/blob/05c95b344a6f8622b357c6f7208297acf5dc447f/include/ttmlir/Target/TTNN/CMakeLists.txt#L17-L19
There was a problem hiding this comment.
Context: this way, we wouldn't need to update the docs each time the options change - they would be read directly from code. Ideally, we also communicate default values by reading them from code.
Ticket
Link to Github Issue
Problem description
Add information about enabling the optimizer in TT-Forge-FE
What's changed
Write up the details from reviewing the code.
Checklist