-
Notifications
You must be signed in to change notification settings - Fork 25
[Deps] Dependency Split #2972
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[Deps] Dependency Split #2972
Conversation
af474b9 to
a3ab778
Compare
a3ab778 to
ab067d1
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2972 +/- ##
=======================================
Coverage 63.55% 63.55%
=======================================
Files 156 156
Lines 11908 11908
=======================================
Hits 7568 7568
Misses 4340 4340 ☔ View full report in Codecov by Sentry. |
a8420a7 to
840c44d
Compare
840c44d to
a720fa9
Compare
d40c88a to
51ab029
Compare
51ab029 to
de4b62c
Compare
2d253e2 to
723d9cb
Compare
3a82b74 to
cf8322d
Compare
f3c87f2 to
687ccf6
Compare
743ed34 to
d13e952
Compare
d13e952 to
8ab9ca4
Compare
|
@nsumrakTT , @vmilosevic Please review the current changes made! |
nsumrakTT
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
| description: "Built CI docker image name" | ||
| value: ${{ jobs.build-image.outputs.docker-image }} | ||
| base-image: | ||
| description: "Built base IRD docker image name" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpick: its not IRD but base image
81229dc to
6eb4cae
Compare
Ticket
Fixes: #1981 , tenstorrent/tt-xla#1826
Problem description
dev-requirements - contains model based requirements
core-requirements - contains compiler based requirements
Changes
Old depedency split PR raised on 3.10 for reference purposes - #2364