Skip tests failing on future uplift #3046
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ckaravasilisTT
requested review from
acolicTT,
dgolubovicTT,
nvukobratTT and
pilkicTT
as code owners
4 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3046 +/- ##
=======================================
Coverage 63.55% 63.55%
=======================================
Files 156 156
Lines 11908 11908
=======================================
Hits 7568 7568
Misses 4340 4340 ☔ View full report in Codecov by Sentry. |
ckaravasilisTT
added a commit
to tenstorrent/tt-mlir
that referenced
this pull request
Nov 18, 2025
…03 2025-11-13 (#5839) This PR uplifts the third_party/tt-metal to the ff303df96bc9bd1c6fff7a4004cd561b9b19f603 **Note** Dockerfile.base is modified due to dependency updates These changes fix compatibility issues after removal of `in_place_halo` introduced by [this](tenstorrent/tt-metal@f596419) commit. Filed an issue to remove `inPlaceHalo` from our IR as it's not really used. PR to disable two failing tests in `forge-fe`. ### Checklist - **Frontend CI passing links** - [ ] [tt-forge-fe](https://github.com/tenstorrent/tt-forge-fe/actions/workflows/on-pr.yml): https://github.com/tenstorrent/tt-forge-fe/actions/runs/19437588555 - [x] [tt-xla (basic + models)](https://github.com/tenstorrent/tt-xla/actions/workflows/manual-test.yml): https://github.com/tenstorrent/tt-xla/actions/runs/19440368958 - **Follow-up Actions** - [x] **Issues filed** to follow up on incomplete changes (if any): #5895 - [x] **Frontend fix PRs** ready (if needed by this uplift): Forge-fe [PR](tenstorrent/tt-forge-fe#3046) --------- Co-authored-by: ckaravasilisTT <[email protected]> Co-authored-by: Chris Karavasilis <[email protected]>
Contributor
|
@ckaravasilisTT do we have some knowledge of what is broken and why? Did we follow up with the metal folks about these issues before disabling these tests? |
Author
|
I suspect the main cause is the changes made to pool2d ops. I intend to follow up with the corresponding authors shortly. I thought this should not block tt-metal uplift longer. |
Contributor
|
FYI, Discussed with @nvukobratTT and added xfail markers instead of skip markers to unblock tt-mlir uplift and created issue for bisecting the failure - #3054 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
#3045
Disable the failing tests from tt-mlir's tt-metal uplift.