[Graph Testing] Enable RGG #315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

vbrkicTT wants to merge 5 commits into main from vbrkic/rgg

Contributor

vbrkicTT commented Sep 18, 2024 •

edited

Loading

Ticket

Resolves tenstorrent/tt-forge-sweeps#7

Problem description

Enable RGG random graph generator testing

What's changed

RGG implementation
RGG documentation
Reformat RGG code

Removed global compiler config
DepricatedVerifyConfig
Use common forge verification
Move random seed logic to test_graphs
Rename PyBuda to Forge
Single RGG pytest
test_commands for rgg
No reducing microbatch size for forge and torch constants
Store test code in pytest report
Operator repo update
Operator support for RGG classified

Checklist

New/Existing tests provide coverage for changes

vbrkicTT added this to the [FFE - 0] Op testing - E2E milestone

vbrkicTT self-assigned this

vbrkicTT requested review from dgolubovicTT, kmilanovicTT, nvukobratTT and vobojevicTT

September 18, 2024 14:24

vbrkicTT marked this pull request as draft

September 18, 2024 14:25

vbrkicTT force-pushed the vbrkic/rgg branch 3 times, most recently from ab700ac to b9f4e63 Compare

September 19, 2024 21:02

vbrkicTT force-pushed the vbrkic/rgg branch from b9f4e63 to 7377d33 Compare

September 27, 2024 07:38

vbrkicTT force-pushed the vbrkic/rgg branch 3 times, most recently from c9aac18 to eb85703 Compare

November 28, 2024 18:06

vbrkicTT marked this pull request as ready for review

November 29, 2024 10:42

vbrkicTT requested a review from pilkicTT as a code owner

November 29, 2024 10:42

vbrkicTT commented

View reviewed changes

forge/forge/op_repo/pybuda_operators.py Show resolved Hide resolved

vbrkicTT force-pushed the vbrkic/rgg branch 6 times, most recently from ef00379 to 2389ee3 Compare

December 4, 2024 14:40

vbrkicTT force-pushed the vbrkic/rgg branch 7 times, most recently from 329081f to e798af9 Compare

December 12, 2024 14:34

vbrkicTT force-pushed the vbrkic/rgg branch from dfa0c31 to b6381db Compare

April 17, 2025 12:17

Collaborator

nvukobratTT commented May 9, 2025

Should this one be converted to draft if it's still WIP?

Contributor

dgolubovicTT commented May 9, 2025

It waits for my review. We had some iterations with @vbrkicTT but we need to review it once more...

Contributor Author

vbrkicTT commented May 13, 2025

The implementation is currently in a stable state. The PR is basically a migration from Buda codebase with many minor and non functional improvements. Further improvements and features we should plan and implement in followup PRs as regular development.

vbrkicTT force-pushed the vbrkic/rgg branch from b6381db to c34e325 Compare

May 26, 2025 07:58

vbrkicTT force-pushed the vbrkic/rgg branch from c34e325 to fe37190 Compare

June 18, 2025 12:21

github-advanced-security bot found potential problems

View reviewed changes

forge/test/random/rgg/base.py Fixed Show fixed Hide fixed

forge/test/random/rgg/base.py Fixed Show fixed Hide fixed

forge/test/random/rgg/datatypes.py

+              class Algorithm:
+                  name: str
+                  GraphBuilderType: Type["GraphBuilder"]

Check warning

Code scanning / flake8

undefined name 'GraphBuilder' Warning test

undefined name 'GraphBuilder'

forge/test/random/rgg/forge/model.py Fixed Show fixed Hide fixed

forge/test/random/rgg/pytorch/model.py Fixed Show fixed Hide fixed

forge/test/random/rgg/pytorch/model.py Fixed Show fixed Hide fixed

forge/test/random/rgg/verify.py Fixed Show fixed Hide fixed

forge/test/random/rgg/verify.py Fixed Show fixed Hide fixed

forge/test/random/rgg/verify.py Fixed Show fixed Hide fixed

forge/test/random/test_graphs.py

+              def test_graphs(
+                  test_index: int,
+                  random_seed: int,
+                  test_device: "TestDevice",

Check warning

Code scanning / flake8

undefined name 'TestDevice' Warning test

undefined name 'TestDevice'

github-advanced-security bot found potential problems

View reviewed changes

forge/test/random/rgg/base.py Fixed Show fixed Hide fixed

forge/test/random/rgg/base.py Fixed Show fixed Hide fixed

forge/test/random/rgg/base.py Fixed Show fixed Hide fixed

forge/test/random/rgg/base.py Fixed Show fixed Hide fixed

forge/test/random/rgg/forge/model.py Fixed Show fixed Hide fixed

forge/test/random/rgg/verify.py Fixed Show fixed Hide fixed

forge/test/random/rgg/verify.py Fixed Show fixed Hide fixed

forge/test/random/rgg/verify.py Fixed Show fixed Hide fixed

forge/test/random/rgg/verify.py Fixed Show fixed Hide fixed

forge/test/random/rgg/verify.py Fixed Show fixed Hide fixed

vbrkicTT force-pushed the vbrkic/rgg branch from fe37190 to a3dfa06 Compare

July 3, 2025 11:55

vbrkicTT requested a review from acolicTT as a code owner

July 3, 2025 11:55

github-advanced-security bot found potential problems

View reviewed changes

forge/test/random/rgg/frameworks.py Fixed Show fixed Hide fixed

vbrkicTT force-pushed the vbrkic/rgg branch 3 times, most recently from abf1893 to 3c8b7eb Compare

July 10, 2025 20:12

vbrkicTT force-pushed the vbrkic/rgg branch 3 times, most recently from ab58c2e to 169a301 Compare

July 29, 2025 16:25

github-advanced-security bot found potential problems

View reviewed changes

forge/test/random/rgg/verify.py


		from typing import List

		from forge import ForgeModule

Check warning

Code scanning / flake8

'forge.ForgeModule' imported but unused Warning test

'forge.ForgeModule' imported but unused

forge/test/random/rgg/verify.py Fixed Show fixed Hide fixed

github-advanced-security bot found potential problems

View reviewed changes

forge/test/random/rgg/verify.py


		from typing import List

		from forge import ForgeModule

Check notice

Code scanning / CodeQL

Unused import Note test

Import of 'ForgeModule' is not used.

Copilot Autofix

AI 4 months ago

To fix the issue, the unused import statement from forge import ForgeModule on line 9 should be deleted. This will remove the unnecessary dependency and make the code cleaner. No other changes are required, as the removal of this import does not affect the functionality of the code.

Suggested changeset 1

forge/test/random/rgg/verify.py

@@ -8,3 +8,2 @@
-            from forge import ForgeModule
             from forge import Module

Copilot is powered by AI and may make mistakes. Always verify output.

forge/test/random/rgg/verify.py Fixed Show fixed Hide fixed

vbrkicTT force-pushed the vbrkic/rgg branch 3 times, most recently from 6d9972c to f9929cc Compare

August 4, 2025 14:46

vbrkicTT force-pushed the vbrkic/rgg branch 2 times, most recently from ea1b1c2 to adec939 Compare

August 22, 2025 15:53

vbrkicTT added 5 commits

August 22, 2025 16:00


          Dynamic skip_forge_verification

ea5c966


          RGG implementation

4c5ed63

RGG implementation
RGG documentation
Reformat RGG code

Removed global compiler config
DepricatedVerifyConfig
Use common forge verification
Move random seed logic to test_graphs
Rename PyBuda to Forge
Single RGG pytest
test_commands for rgg
No reducing microbatch size for forge and torch constants
Store test code in pytest report
Operator repo update
Operator support for RGG classified


          OperatorList

d35bc33

Unsupported list of operators
Multiple values for skip_forge_verification in RGG


          Update RGG operator status

5f7c2ef


          NOT_IMPLEMENTED_PYTORCH via test_data

ffc036c

vbrkicTT force-pushed the vbrkic/rgg branch from adec939 to ffc036c Compare

August 22, 2025 16:00

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

nvukobratTT Awaiting requested review from nvukobratTT nvukobratTT is a code owner

dgolubovicTT Awaiting requested review from dgolubovicTT dgolubovicTT is a code owner

vobojevicTT Awaiting requested review from vobojevicTT

kmilanovicTT Awaiting requested review from kmilanovicTT

pilkicTT Awaiting requested review from pilkicTT pilkicTT is a code owner

acolicTT Awaiting requested review from acolicTT acolicTT is a code owner

At least 1 approving review is required to merge this pull request.

Labels

None yet