Refactor pixtal/loader.py and fix load_inputs function#402
Open
devisettymahidhar608 wants to merge 1 commit intomainfrom
Open
Refactor pixtal/loader.py and fix load_inputs function#402devisettymahidhar608 wants to merge 1 commit intomainfrom
devisettymahidhar608 wants to merge 1 commit intomainfrom
Conversation
ee0b92d to
0785910
Compare
sonalibaskaran2499
approved these changes
Jan 21, 2026
0785910 to
4a79156
Compare
Contributor
|
Adding @AleksKnezevic - Thanks for changes @devisettymahidhar608 - I'd like to get some input from Aleks on what to do here, since this model is currently running (but with low PCC lately, and incorrect loader.py), do we merge these changes which causes the model to not run e2e anymore until the issue you opened tenstorrent/tt-xla#2924 gets assigned and debugged. Side Note - We should hold off a bit on merging this until tt-forge-models recent uplift issues (a week out of date in tt-xla) get resolved. |
Contributor
|
Commented on the other issue, we can't support any dynamic shapes through the compiler right now. We'll need to debug why we're seeing this dynamism. |
3684d4a to
90a3dad
Compare
90a3dad to
0eb2335
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
Link to Github Issue
Problem description
Debug PCC drop in the model
What's changed
Upon inspecting the load_inputs function, it returns the following keys: input_ids and attention_mask.
While running the model from Hugging Face in Google Colab, I observed a difference in the input keys being passed to the model.
The following keys are being sent to the model: ['input_ids', 'attention_mask', 'pixel_values', 'image_sizes'].
loader.py only sends input_ids and attention_mask; pixel_values and image_sizes are not included.
Edited loader.py to ensure correct inputs are passed to the model.
While running the Mistral/pixtral model, I encountered the following error:
loc("set-dimension-size.60"): Shardy propagation only supports ranked tensors with a static shape. The tensor type causing the issue is tensor>. pixtral.logIssue originats from the masked_scatter - sanity.log
Checklist