refactor model weights, utils for yoloworld variants to follow the new naming convention #481
Open
ashokkumarkannan1 wants to merge 1 commit intomainfrom
Open
refactor model weights, utils for yoloworld variants to follow the new naming convention #481ashokkumarkannan1 wants to merge 1 commit intomainfrom
ashokkumarkannan1 wants to merge 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem description
Model variant names were updated to follow the new naming convention introduced in this PR:
Update model names to human-readable format for presentation (#447) #472
However, this change breaks existing model loading because:
a) Model weights stored in S3 are resolved using the variant name -
s3://tt-ci-models-private/test_files/pytorch/yoloworld/b) Configuration loading logic also depends on the variant name.
As a result, renaming the variants without updating corresponding assets and references causes weight resolution and config loading failures.
What’s Changed
Checklist
Logs