Open
Conversation
ddilbazTT
requested review from
nsumrakTT,
odjuricicTT,
rpavlovicTT,
tt-mpantic,
vkovacevicTT,
vmilosevic and
vvukomanTT
as code owners
Contributor
Author
|
I'll attach the logs from 2x4 and 1x8 meshes |
nsumrakTT
approved these changes
Feb 9, 2026
odjuricicTT
requested changes
Feb 9, 2026
Collaborator
odjuricicTT
left a comment
odjuricicTT
left a comment
There was a problem hiding this comment.
Awesome! Thanks for adding!
Requesting changes because of default optimization level.
vvukomanTT
approved these changes
Feb 9, 2026
ddilbazTT
force-pushed
the
ddilbaz/new_gpt_oss_20b
branch
2 times, most recently
from
12d0c86 to
728a94c
Compare
ddilbazTT
force-pushed
the
ddilbaz/new_gpt_oss_20b
branch
from
728a94c to
1c9e1e6
Compare
…mization level and prompt.
ddilbazTT
force-pushed
the
ddilbaz/new_gpt_oss_20b
branch
from
1c9e1e6 to
cdb4a5f
Compare
odjuricicTT
reviewed
Feb 10, 2026
benchmark/tt-xla/test_llms.py
Outdated
Comment on lines
174
to
175
| batch_size=None, | ||
| optimization_level=None, |
Collaborator
There was a problem hiding this comment.
You should be able to pass batch_size and optimization_level without adding them as explicit arguments here. They will be picked up in **kwargs?
benchmark/tt-xla/test_llms.py
Outdated
Comment on lines
183
to
186
| if batch_size is None: | ||
| batch_size = DEFAULT_BATCH_SIZE | ||
| if optimization_level is None: | ||
| optimization_level = DEFAULT_OPTIMIZATION_LEVEL |
Collaborator
There was a problem hiding this comment.
Not needed is removed from function signature.
ddilbazTT
force-pushed
the
ddilbaz/new_gpt_oss_20b
branch
from
c87efef to
5f20110
Compare
ddilbazTT
force-pushed
the
ddilbaz/new_gpt_oss_20b
branch
from
5f20110 to
cdc5018
Compare
Contributor
Author
|
@odjuricicTT https://github.com/tenstorrent/tt-forge/actions/runs/21906541734/job/63248243625 Here is the test I added running for reference. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding gpt-oss-20b tp benchmark test to tt-forge. Several notes about gpt-oss-20b: