Open
Conversation
1 task
1 task
nsumrakTT
reviewed
Feb 13, 2026
Contributor
nsumrakTT
left a comment
There was a problem hiding this comment.
Why we have fail-notify on each test suite (basic, demo, perf)? Especially on workflow_dispatch, if you dispatch workflow you won't need notification...
Contributor
Author
|
@nsumrakTT |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
With the switch of the release process to tt-xla, the triggering logic for fail message has to change.
Solution
Introduce a flag which defines whether the fail notification should be sent.
note: When perf benchmark is fully tested on tt-xla and we switch to it, this flag won't be used there. We will trigger fail notifications there based on what workflow called the perf benchmark. (e.g. notifications sent if perf triggered by schedule-nightly.yml)