Skip to content

Add the fail-notify flag to perf benchmark#888

Open
vvukomanTT wants to merge 4 commits intomainfrom
vvukoman/add-fail-notify-perf-flag
Open

Add the fail-notify flag to perf benchmark#888
vvukomanTT wants to merge 4 commits intomainfrom
vvukoman/add-fail-notify-perf-flag

Conversation

@vvukomanTT
Copy link
Contributor

Problem

With the switch of the release process to tt-xla, the triggering logic for fail message has to change.

Solution

Introduce a flag which defines whether the fail notification should be sent.

note: When perf benchmark is fully tested on tt-xla and we switch to it, this flag won't be used there. We will trigger fail notifications there based on what workflow called the perf benchmark. (e.g. notifications sent if perf triggered by schedule-nightly.yml)

Copy link
Contributor

@nsumrakTT nsumrakTT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why we have fail-notify on each test suite (basic, demo, perf)? Especially on workflow_dispatch, if you dispatch workflow you won't need notification...

@vvukomanTT
Copy link
Contributor Author

@nsumrakTT
We can't really filter on workflow disptach type since triggers from other repos are also seen as workflow_dispatchs.
This is off by default so it won't trigger messages unless someone specifies it + the workflow has to be on main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants