POC: matmul support and get singlecore matmul example working#207
Draft
zoecarver wants to merge 13 commits intozoecarver/ttl-skillsfrom
Draft
POC: matmul support and get singlecore matmul example working#207zoecarver wants to merge 13 commits intozoecarver/ttl-skillsfrom
zoecarver wants to merge 13 commits intozoecarver/ttl-skillsfrom
Conversation
zoecarver
commented
Jan 2, 2026
| # SPDX-FileCopyrightText: (c) 2025 Tenstorrent AI ULC | ||
| # | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
| # up to tt-lang spec, not intended to compile or run currently |
Contributor
Author
There was a problem hiding this comment.
Not proposing these changes to the example. Once this is ready for review, I'll add proper tests and leave this untouched until we have dynamic indexing.
zoecarver
commented
Jan 2, 2026
| golden = torch.matmul(a_torch, b_torch) | ||
| result = ttnn.to_torch(c).to(torch.bfloat16) | ||
| print(result) | ||
| assert_with_ulp(golden, result) |
Contributor
Author
There was a problem hiding this comment.
Example output (no assert):
tensor([[ 8.2500, 10.1250, 9.7500, ..., 9.2500, 8.2500, 9.0625],
[ 6.0938, 8.0000, 8.0625, ..., 7.1250, 6.8750, 7.7188],
[ 8.1875, 9.7500, 8.9375, ..., 7.6875, 7.7812, 9.1250],
...,
[ 8.9375, 9.6875, 9.9375, ..., 8.1250, 8.3750, 10.3125],
[ 8.3125, 9.9375, 7.6562, ..., 8.0625, 7.8438, 8.3125],
[ 9.0000, 10.9375, 9.0625, ..., 8.1875, 9.0000, 10.0000]],
dtype=torch.bfloat16)
[5070] 1.5 seconds (3.3 KHz)
========================================
TEST PASSED
========================================
b83565c to
b110bb7
Compare
8705fef to
f02b96b
Compare
commit f3928e2 Author: Zoe Carver <zcarver@tenstorrent.com> Date: Tue Jan 20 10:09:27 2026 -0500 use pytest commit 57d7bc5 Author: Zoe Carver <zcarver@tenstorrent.com> Date: Tue Jan 20 10:05:43 2026 -0500 pre commit commit ea32b74 Author: Zoe Carver <zcarver@tenstorrent.com> Date: Tue Jan 20 10:04:21 2026 -0500 Fix bug with tensor accessors on intermediate cbs
b110bb7 to
adbe45e
Compare
6e4de6f to
3b30b5c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOT FOR REVIEW
Just a proof of concept to scope out matmul support.