Draft
Conversation
9076f6d to
c1edbd0
Compare
c1edbd0 to
47a6f48
Compare
7f08b2e to
97df6d7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Annotate the binary tile operations (add, sub, mul) that can use the FPU instead of SFPU.
Why?
FPU performance is much better (~2x) than SFPU for add, sub, mul.
How?
Binary operations are classified into three strategies based on operand provenance:
execution_target = "fpu"add_tiles(cb0, cb1, ...)execution_target = "dest_reuse"binary_dest_reuse_tiles(cb, ...)execution_target = "sfpu"or no attributeadd_binary_tile(dst0, dst1, ...)How to Test?
New MLIR test:
test/ttlang/Conversion/TTLToCompute/test_annotate_binary_strategy.mlirFuture
Checklist: