Draft
Conversation
- Add call-build-ttmlir-toolchain.yml as dedicated cache builder
- Simplify CI workflow to restore cache with fail-on-cache-miss
- Simplify container workflow to use same unified cache
- Update Docker build to require pre-built toolchain via
--ttmlir-toolchain
- Update Dockerfile to use toolchain from build context
- Make ccache caching actually work by caching it per-ref not per
commit
- Add CI_WORKFLOWS.md documentation
- Update BUILD_SYSTEM.md, containers/README.md with new architecture
- Refactor common functionality into helper scripts
Follows GitHub Actions best practice: dedicated workflow builds and
caches dependencies, other workflows consume with fail-on-cache-miss.
7a423f1 to
94d4485
Compare
remove dependence on tt-mlir container Updated container docs with new image names: - tt-lang-dev-ubuntu-22-04 - toolchain + dev tools (for developers) - tt-lang-user-ubuntu-22-04 - dev + tt-lang (for end users)
- Split toolchain workflow into check-cache (ubuntu-latest) and build (large runner) - Change schedule from weekly to nightly - Remove redundant push trigger, add pull_request trigger for tt-mlir.commit changes - Fix Docker workflow to use determine-ttmlir-commit.sh and honor mlir_override input - Ensure consistent cache key format across all workflows
2cbc340 to
a52173c
Compare
9e20814 to
ce9c88a
Compare
ce9c88a to
6f88cd5
Compare
7d4f0a0 to
f4f6d1a
Compare
3a9566e to
56c4b65
Compare
d7a6632 to
83896ec
Compare
fdf4b0e to
e3e964b
Compare
e3e964b to
f96f287
Compare
2670e35 to
eb50c13
Compare
eb50c13 to
c4b7630
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: Unnecessary rebuilding of the same tt-mlir; Docker container builds time out as a result but also (some) regular CI jobs take longer than they should. Inconsistent caching.
Solution:
New on-pr workflow:
Follows GitHub Actions best practice: dedicated workflow builds and caches dependencies, other workflows consume with fail-on-cache-miss.
When the toolchain cache needs rebuilding, the regular on-pr workflow fails with a clear error message and instructions, e.g.:
Checklist: