Adds reduce_sum and reduce_max operations #300
Open
zoecarver wants to merge 7 commits intozoecarver/matmul-opfrom
Open
Adds reduce_sum and reduce_max operations #300zoecarver wants to merge 7 commits intozoecarver/matmul-opfrom
zoecarver wants to merge 7 commits intozoecarver/matmul-opfrom
Conversation
fc646f5 to
2d9f3ed
Compare
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
bc85e71 to
e74c621
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
reduce_sumandreduce_maxoperations following the same CB-input pattern as bcast and matmul.TTL_CBInputTileOpTraitfor proper DST assignment handlingConvertTTLToComputebuilds the reduction loop structure with proper scaler handling.ConvertTTLTileOpsToTTKernelemits the appropriate reduce intrinsic based on reduction type and dimensionSelf-contained and follows bcast's established lowering path and reuses the same CB lookup utilities. Risk is limited to reduce ops (adds new lowering, does not modify existing lowering patterns).