Open
Conversation
brnorris03
approved these changes
Feb 11, 2026
Contributor
brnorris03
left a comment
brnorris03
left a comment
There was a problem hiding this comment.
Would prefer to have MLIR lit tests (as is normally done for any new ops), otherwise lgtm.
brnorris03
reviewed
Feb 11, 2026
Comment on lines
+845
to
+849
| for (Value yielded : yieldOp.getValues()) { | ||
| auto arg = dyn_cast<BlockArgument>(yielded); | ||
| if (!arg || !isTileValue(arg)) { | ||
| continue; | ||
| } |
Contributor
There was a problem hiding this comment.
Could consider marking ttl.compute (e.g., computeOp->setDiscardableAttr("ttl.passthrough", rewriter.getUnitAttr()); when creating pass through computes and check that attribute instead of checking yielded values.
brnorris03
reviewed
Feb 11, 2026
Comment on lines
+902
to
+906
| if (getAttachedCB(input)) { | ||
| return op.emitError( | ||
| "passthrough tensor_store should be lowered to ComputeOp first; " | ||
| "ensure convert-ttl-to-compute runs before this pass"); | ||
| } |
Contributor
There was a problem hiding this comment.
negative test for this error?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a frontend store op and lower it all the way to pack tile; a few related fixes.
This is a temporary fix, Boyana may have a cleaner approach, using this branch to unblock claude skills.