Skip to content

Update targets for galaxy Whisper test #37042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dpopovTT merged 1 commit into from
Feb 3, 2026
Merged

Update targets for galaxy Whisper test #37042

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion models/demos/audio/whisper/demo/demo.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -784,7 +784,7 @@ def test_demo_for_conditional_generation(
metrics_dictionary = {
2: {"prefill_time_to_token": 0.13, "decode_t/s/u": 124.0},
8: {"prefill_time_to_token": 0.14, "decode_t/s/u": 105.0},
32: {"prefill_time_to_token": 0.21, "decode_t/s/u": 80.0},
32: {"prefill_time_to_token": 0.22, "decode_t/s/u": 77.5},
Copy link

Copilot AI Feb 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR description acknowledges a regression in the Whisper model on Galaxy (wormhole_b0), but does not provide an explanation of the root cause. Performance degradations of approximately 4.8% for prefill_time_to_token (0.21 → 0.22) and 3.1% for decode_t/s/u (80.0 → 77.5) should be investigated and documented. Consider adding a comment explaining why this regression is expected/acceptable, or linking to an issue tracking the investigation and potential fix.

Copilot uses AI. Check for mistakes.
}
if is_blackhole():
if mesh_device.dram_grid_size().x == 7: # P100 DRAM grid is 7x1
Expand Down
Loading