Skip to content

#29206 certain model comparison mode failed for bcast op golden function#37890

Open
dchenTT wants to merge 1 commit intomainfrom
dchen/29206-bcast_golden
Open

#29206 certain model comparison mode failed for bcast op golden function#37890
dchenTT wants to merge 1 commit intomainfrom
dchen/29206-bcast_golden

Conversation

@dchenTT
Copy link
Contributor

@dchenTT dchenTT commented Feb 13, 2026

Ticket

Link to Github Issue

Problem description

model comparison mode does not work for sd model, due to bcast op

What's changed

bcast being an old op, no longer being developed. has a strange, not standard broadcast behavior. For example,
in0 = (1, 1, 64, 64)
in1 = (2, 1, 1, 64)
It is legit broadcast, the output should be (2, 1, 64, 64). But the actual bcast op output is (1,1,64, 64). Only H W dim is truly broadcasted and non H W dim is truncated to in0 shape. Also ideally model should not use this behavior as well. But I think it is a historical artifact.

The change is to change golden function to slice to the desired output golden tensor

Checklist

  • All post-commit tests
  • Blackhole Post commit
  • cpp-unit-tests
  • New/Existing tests provide coverage for changes

Model tests

If your changes cover model-related code, you should run tests corresponding to affected models and platforms (Single card, T3K, Galaxy). "Choose your pipeline" workflows facilitate running multiple kinds of tests in a single run. Each offers models-mandatory and models-extended presets.
The former includes a minimal set of tests, to be run always. The latter extends that with additional ones - use your best judgement in deciding which is the most appropriate for your PR.

@dchenTT dchenTT requested review from a team as code owners February 13, 2026 22:21
Copilot AI review requested due to automatic review settings February 13, 2026 22:21
@dchenTT dchenTT self-assigned this Feb 13, 2026
@dchenTT dchenTT requested review from Aswinmcw and removed request for Copilot February 13, 2026 22:22
@dchenTT
Copy link
Contributor Author

dchenTT commented Feb 13, 2026

/codeowner ping

@tenstorrent-github-bot
Copy link

CodeOwners Group Analysis

This PR requires approval from one member of each of the following groups:

Summary: 1 pending groups, 0 approved groups

Group Information:

Note: At least one approval from each group is sufficient.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants