Fix cplusplus.Move: remove access to moved-from object in StrongType test

[Copilot]

Ticket

Link to Github Issue

Problem description

Clang Static Analyzer flags cplusplus.Move violation in tt_stl/tests/test_strong_type.cpp:78 — test accessed a moved-from StrongType<unique_ptr<int>> to verify the wrapped pointer was null. Accessing moved-from objects is undefined behavior per C++ standard.

What's changed

Removed assertion that dereferenced the moved-from object. Test now only validates the moved-to object contains expected value, which sufficiently verifies move semantics without UB.

Before:

MoveOnlyType to = std::move(from);
// NOLINTNEXTLINE(bugprone-use-after-move)
EXPECT_THAT(*from, IsNull());  // UB: accessing moved-from object
EXPECT_EQ(**to, 42);

After:

MoveOnlyType to = std::move(from);
EXPECT_EQ(**to, 42);  // Sufficient to validate move succeeded

Checklist

• 
• 
• 
• New/Existing tests provide coverage for changes

Model tests

If your changes cover model-related code, you should run tests corresponding to affected models and platforms (Single card, T3K, Galaxy). "Choose your pipeline" workflows facilitate running multiple kinds of tests in a single run. Each offers models-mandatory and models-extended presets.
The former includes a minimal set of tests, to be run always. The latter extends that with additional ones - use your best judgement in deciding which is the most appropriate for your PR.

• 

  • models-mandatory preset (runs: Device perf regressions and Frequent model and ttnn tests)
  • models-extended preset (runs: the mandatory tests, plus Demo and Model perf tests)
  • other selection - specify runs

• 

  • models-mandatory preset (runs: Unit tests)
  • models-extended preset (runs: the mandatory tests, plus Demo and Model perf tests)
  • other selection - specify runs

• 

  • models-mandatory preset (runs: Quick tests)
  • models-extended preset (runs: the mandatory tests, plus Demo and Model perf tests)
  • other selection - specify runs

Original prompt

Fix this Clang Static Analyzer issue:

• cplusplus.Move in tt_stl/tests/test_strong_type.cpp:78 — Method called on moved-from object 'from'

Verify it's a real issue, apply minimal fix, follow coding standards.

---

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

[Copilot]

Pull request overview

This PR fixes a Clang Static Analyzer issue where a moved-from std::unique_ptr wrapped in StrongType was being accessed, which is undefined behavior. The fix removes the problematic assertion that attempted to verify the moved-from object's state, keeping only the verification of the moved-to object.

Changes:

• Removed two lines that accessed a moved-from StrongType<std::unique_ptr<int>> object, eliminating undefined behavior
• The test now correctly validates only the moved-to object contains the expected value

[blozano-tt]

I agree with copilot, clang static analyzer, and clang-tidy.

Let’s just delete this code.

[blozano-tt]

/codeowners ping

[tenstorrent-github-bot]

CodeOwners Group Analysis

This PR requires approval from one member of each of the following groups:

Summary: 1 pending groups, 0 approved groups

Group Information:

• ⏳ tt_stl/ (Group) - Members: Artem Yerofieiev, Audrey Kertesz | Pending approval

  📁 Files owned by this group (1 files)

  • tt_stl/tests/test_strong_type.cpp

Note: At least one approval from each group is sufficient.

[tenstorrent-github-bot]

Hi Audrey Kertesz (@akerteszTT), Artem Yerofieiev (@ayerofieiev-tt), this PR Fix cplusplus.Move: remove access to moved-from object in StrongType test by Copilot (@Copilot) needs your approval/review to merge this.