added datype arguments for ttir operations and testcases #5036

HariK3927 · 2025-09-21T11:06:55Z

Ticket

#2094

Problem description

Added dataarguments for ttir operations

What's changed

added the dtype arguments and done the changes in test files for verification.

Checklist

New/Existing tests provide coverage for changes

svuckovicTT · 2025-09-23T13:10:35Z

include/ttmlir/Dialect/TTIR/IR/TTIROps.td

  }];

-  let arguments = (ins DenseI32ArrayAttr:$shape);
+  let arguments = (ins DenseI32ArrayAttr:$shape,TypeAttr:$dtype);


Fix formatting

svuckovicTT · 2025-09-23T13:10:47Z

include/ttmlir/Dialect/TTIR/IR/TTIROps.td

    starting point for accumulation operations.
  }];
+  let arguments = (ins DenseI32ArrayAttr:$shape,
+                       TypeAttr:$dtype);  // Added dtype argument


Instead of adding this directly to zerosop, add to TTIR_NamedFullOp so that it applied to all named full-like ops (ones, zeros, etc.)

svuckovicTT · 2025-09-23T13:11:09Z

lib/Conversion/TTIRToTTIRDecomposition/TTIRToTTIRDecomposition.cpp

+
+    // Create TypeAttr for the dtype argument


Remove comment

Removed the comment

svuckovicTT · 2025-09-23T13:11:56Z

lib/Conversion/TTIRToTTIRDecomposition/TTIRToTTIRDecomposition.cpp

            .create<ttir::ArangeOp>( // perform arange on the last dimension to
                                     // match how ttnn behaves
-                op.getLoc(), arangeOutputType, start, end, step, 0)
+                op.getLoc(), arangeOutputType, start, end, step, 0,outputType.getElementType())


Suggested change

op.getLoc(), arangeOutputType, start, end, step, 0,outputType.getElementType())

op.getLoc(), arangeOutputType, start, end, step, 0, outputType.getElementType())

fixed formatting

svuckovicTT · 2025-09-23T13:12:09Z

test/ttmlir/Dialect/TTIR/const-eval/const-eval.mlir

  func.func @forward_reuse_zeros(%arg0: tensor<32x32xbf16> {ttcore.argument_type = #ttcore.argument_type<input>}, %arg1: tensor<32x32xbf16> {ttcore.argument_type = #ttcore.argument_type<parameter>}, %arg2: tensor<32x32xbf16> {ttcore.argument_type = #ttcore.argument_type<parameter>}, %arg3: tensor<32x32xbf16> {ttcore.argument_type = #ttcore.argument_type<constant>}) -> tensor<32x32xbf16> {
      // CHECK: = ttcore.load_cached(@forward_reuse_zeros_const_eval_0, [%arg1, %arg2])
-      %0 = "ttir.zeros"() <{shape = array<i32:32, 32>}> : () -> tensor<32x32xbf16>
+      %0 = "ttir.zeros"() <{shape = array<i32:32, 32>,dtype = i64}> : () -> tensor<32x32xbf16>


Suggested change

%0 = "ttir.zeros"() <{shape = array<i32:32, 32>,dtype = i64}> : () -> tensor<32x32xbf16>

%0 = "ttir.zeros"() <{shape = array<i32:32, 32>, dtype = i64}> : () -> tensor<32x32xbf16>

fixed the formatting

svuckovicTT · 2025-09-23T13:14:46Z

test/ttmlir/Silicon/TTNN/n150/zeros.mlir

  func.func @zeros_f32() -> tensor<32x64x128xf32> {
    // CHECK: {{.*}} = "ttnn.zeros"({{.*}}) {{.*}} -> tensor<32x64x128xf32{{.*}}>
-    %0 = "ttir.zeros"() <{shape = array<i32:32, 64, 128>}> : () -> tensor<32x64x128xf32>
+    %0 = "ttir.zeros"() <{shape = array<i32:32, 64, 128>,dtype = i64}> : () -> tensor<32x64x128xf32>


Suggested change

%0 = "ttir.zeros"() <{shape = array<i32:32, 64, 128>,dtype = i64}> : () -> tensor<32x64x128xf32>

%0 = "ttir.zeros"() <{shape = array<i32:32, 64, 128>, dtype = i64}> : () -> tensor<32x64x128xf32>

fixed the formatting

svuckovicTT · 2025-09-23T13:15:09Z

test/ttmlir/EmitC/TTNN/tensor/zeros.mlir


 func.func @zeros() -> tensor<13x24x56x42xbf16> {
-  %0 = "ttir.zeros"() <{shape = array<i32:13, 24, 56, 42>}> : () -> tensor<13x24x56x42xbf16>
+  %0 = "ttir.zeros"() <{shape = array<i32:13, 24, 56, 42>, dtype = i64}> : () -> tensor<13x24x56x42xbf16>


You've added i64 in many other places, please fix everywhere.

changed according to the return type

HariK3927 · 2025-10-05T09:41:05Z

@svuckovicTT fixed the changes and passed the tests successfully.Can you please review?

svuckovicTT · 2025-10-09T09:42:14Z

Hey @HariK3927, I've enabled the CI pipeline, there are some failures in the pre-commit stage. You can look at the logs and manually fix things, but I suggest installing the pre-commit hooks and running the tool which will do this automatically for you. You can find more info here: https://docs.tenstorrent.com/tt-mlir/getting-started.html?#pre-commit

svuckovicTT · 2025-10-20T08:51:09Z

@nsumrakTT @vvukomanTT Hey guys, any ideas why the prepare-run job might be failing for this bounty?

nsumrakTT · 2025-10-20T09:25:20Z

@svuckovicTT Yes, permission error, I'll fix in separate PR.

svuckovicTT · 2025-10-20T12:55:03Z

@HariK3927 can you please rebase once this PR lands? I'll launch tests after. Thanks!

#5398

HariK3927 · 2025-10-21T16:06:03Z

@svuckovicTT It seems the build fix PR is merged to main.Shall I merge this PR to updated main or rebasing needed ?

nsumrakTT · 2025-10-21T16:14:39Z

@HariK3927 Whatever is easier for you.

HariK3927 · 2025-10-21T17:17:42Z

@nsumrakTT I have merged to latest main branch . If anyfurther changes required please let me know . Thank you.

HariK3927 · 2025-10-27T05:47:57Z

@svuckovicTT yes using this command fixed the errors and passed the build .Hope some luck this time

HariK3927 · 2025-11-02T12:51:31Z

@nsumrakTT @svuckovicTT Can I execute CI workflow ?
I have fixed the build errors .It will be easy If I have access of CI workflow execution since some errors are not visible in local?

anuragsingh-tt · 2025-11-04T16:27:03Z

Hi @HariK3927, you should be able to reproduce the error for some of these failing tests on your side. E.g:
ttmlir/Conversion/StableHLOToTTIR/data_movement/sort_op.mlir

Can I execute CI workflow ?

Refer to this to run the test suite locally. It does not cover all the CI tests but is a good sanity check.

…ations

codecov-commenter · 2025-11-08T13:03:47Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.23%. Comparing base (5b898c5) to head (8bc9585).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5036      +/-   ##
==========================================
+ Coverage   69.21%   69.23%   +0.02%     
==========================================
  Files         333      333              
  Lines       50762    50766       +4     
==========================================
+ Hits        35136    35150      +14     
+ Misses      15626    15616      -10

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…ations

anuragsingh-tt

test_ones is still failing.

HariK3927 · 2025-11-10T20:32:31Z

Will check

HariK3927 requested review from a team and mrakitaTT as code owners September 21, 2025 11:06

HariK3927 requested review from azecevicTT, jserbedzijaTT, mtopalovicTT, sdjordjevicTT, svuckovicTT and vwellsTT September 21, 2025 11:06

github-actions bot added the community label Sep 21, 2025

added datype arguments for ttir operations and testcases

f34e144

svuckovicTT requested changes Sep 23, 2025

View reviewed changes

svuckovicTT linked an issue Sep 23, 2025 that may be closed by this pull request

[$200 Bounty]TTIR tensor creation ops missing DataType arguments #2094

Open

HariK3927 added 3 commits September 26, 2025 05:59

Merge branch 'main' into Adding_Dataarguments_to_ttiroperations

e8cf35a

Merge branch 'main' into Adding_Dataarguments_to_ttiroperations

af33995

Merge branch 'main' into Adding_Dataarguments_to_ttiroperations

99d3481

fixed datatype conventions in test files

a7d435b

HariK3927 and others added 5 commits October 10, 2025 10:54

Merge branch 'main' into Adding_Dataarguments_to_ttiroperations

32a5731

Merge branch 'main' into Adding_Dataarguments_to_ttiroperations

2432da4

fixing line of endings

2f324a0

Merge branch 'main' into Adding_Dataarguments_to_ttiroperations

d2457d0

Merge branch 'main' into Adding_Dataarguments_to_ttiroperations

6459399

Merge branch 'main' into Adding_Dataarguments_to_ttiroperations

663530e

HariK3927 requested a review from a team as a code owner October 26, 2025 15:33

HariK3927 requested review from ajakovljevicTT, anuragsingh-tt, mmanzoorTT, tapspatel and wooseokTT October 26, 2025 15:33

HariK3927 and others added 3 commits October 26, 2025 21:04

fixing the build issues

ac31e57

Merge branch 'main' into Adding_Dataarguments_to_ttiroperations

a221f54

Merge branch 'main' into Adding_Dataarguments_to_ttiroperations

d3d80b5

HariK3927 and others added 3 commits October 28, 2025 06:16

Merge branch 'main' into Adding_Dataarguments_to_ttiroperations

9cec53e

fixing build issues of arguments

c4f15a9

Merge branch 'main' into Adding_Dataarguments_to_ttiroperations

e7f739e

HariK3927 and others added 5 commits November 4, 2025 22:55

fixing the test cases

7d3dbaa

Merge branch 'main' into Adding_Dataarguments_to_ttiroperations

7bee093

Merge branch 'main' into Adding_Dataarguments_to_ttiroperations

5787305

Merge branch 'tenstorrent:main' into Adding_Dataarguments_to_ttiroper…

bf043c3

…ations

fix the data arguments in test cases

a3334c4

HariK3927 added 2 commits November 8, 2025 18:35

Merge branch 'tenstorrent:main' into Adding_Dataarguments_to_ttiroper…

3e88e6b

…ations

Merge branch 'main' into Adding_Dataarguments_to_ttiroperations

7b8c16d

anuragsingh-tt requested changes Nov 10, 2025

View reviewed changes

HariK3927 and others added 5 commits November 18, 2025 21:58

fix

7677be1

Merge branch 'main' into Adding_Dataarguments_to_ttiroperations

979e4f9

resetting the ttirops test changes

f6864ee

Merge branch 'main' into Adding_Dataarguments_to_ttiroperations

8bc9585

added thedata arguments in golden test

98ddf8a

	op.getLoc(), arangeOutputType, start, end, step, 0,outputType.getElementType())
	op.getLoc(), arangeOutputType, start, end, step, 0, outputType.getElementType())

	%0 = "ttir.zeros"() <{shape = array<i32:32, 32>,dtype = i64}> : () -> tensor<32x32xbf16>
	%0 = "ttir.zeros"() <{shape = array<i32:32, 32>, dtype = i64}> : () -> tensor<32x32xbf16>

added datype arguments for ttir operations and testcases #5036

Are you sure you want to change the base?

added datype arguments for ttir operations and testcases #5036

Uh oh!

Conversation

HariK3927 commented Sep 21, 2025

Ticket

Problem description

What's changed

Checklist

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

HariK3927 commented Oct 5, 2025

Uh oh!

svuckovicTT commented Oct 9, 2025

Uh oh!

svuckovicTT commented Oct 20, 2025

Uh oh!

nsumrakTT commented Oct 20, 2025

Uh oh!

svuckovicTT commented Oct 20, 2025

Uh oh!

HariK3927 commented Oct 21, 2025

Uh oh!

nsumrakTT commented Oct 21, 2025

Uh oh!

HariK3927 commented Oct 21, 2025

Uh oh!

HariK3927 commented Oct 27, 2025

Uh oh!

HariK3927 commented Nov 2, 2025

Uh oh!

anuragsingh-tt commented Nov 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov-commenter commented Nov 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

anuragsingh-tt left a comment

Choose a reason for hiding this comment

Uh oh!

HariK3927 commented Nov 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

anuragsingh-tt commented Nov 4, 2025 •

edited

Loading

codecov-commenter commented Nov 8, 2025 •

edited

Loading

HariK3927 commented Nov 10, 2025 •

edited

Loading