Change linear op rewrite pattern #6014
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
#5813
#6016
Problem description
During uplift 2 weeks ago, default tt-metal/ttnn linear op behaviour has changed. linear op is now mapping PyTorch Linear This means that linear op bias needs to be 1d (or view, like 1x1x64)
@ctodTT relaxed the conditions to linear op workaround so that all linear ops would be broken down into matmul and add. However, this means no linear op is running as a linear op, even if they have 1d bias.
What's changed
Linear op workaround is changed such that:
Tests marked unsupported or skipped are reinstated.
Checklist