Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6989 +/- ##
==========================================
- Coverage 69.14% 69.05% -0.09%
==========================================
Files 381 381
Lines 67044 67096 +52
==========================================
- Hits 46357 46333 -24
- Misses 20687 20763 +76 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
/
Problem description
StableHLO Sort Op sometimes produces TTIR Gather Ops, but we want to remove the generic TTIR Gather Op that mimics StableHLO Gather (#6579).
What's changed
Changed the kKeyValue SortType case of StableHLOToTTIRSortOpConversionPattern - removed TTIR Gather Ops and necessary transformations for its input, now TTIR Embedding Op is emitted directly.
In detail
For every tensor that needs to be reordered according to indices:
Indices are transformed differently depending on whether sort dim was first, last or in the middle:
Case 1: sortDim = last (most common, stride = 1, no multiply needed)
Case 2: sortDim = first (stride = post)
sort contribution
Case 3: sortDim in middle (stride = post, need 3D intermediate)
offsets[p, j, q] = p * d_sort * post + q (fully known at compile time — no
runtime compute on accelerator)
sort contribution
Checklist