Skip to content

Move global_cache implementation to operations/cache#7012

Open
nsumrakTT wants to merge 1 commit intomainfrom
nsumrak/move-global-cache-to-cacheops
Open

Move global_cache implementation to operations/cache#7012
nsumrakTT wants to merge 1 commit intomainfrom
nsumrak/move-global-cache-to-cacheops

Conversation

@nsumrakTT
Copy link
Contributor

Ticket

tenstorrent/tt-xla#922

Problem description

tt-xla manylinux build fails because of circular dependency between global cache and load cache

What's changed

Different versions of build tools and environment causes more rigid check.
Load cache is inside TTNNOps lib while global cache singleton is in parent lib TTNN, and load cache uses global cache.
The problem is in linking, probably in resolving statics for singleton.
Solution is to move global cache into TTNNOps (operations/cache).

Checklist

  • New/Existing tests provide coverage for changes

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.15%. Comparing base (dceaf55) to head (8e83cdf).
⚠️ Report is 20 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7012      +/-   ##
==========================================
+ Coverage   69.04%   69.15%   +0.10%     
==========================================
  Files         380      382       +2     
  Lines       66860    67071     +211     
==========================================
+ Hits        46166    46384     +218     
+ Misses      20694    20687       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants