Move global_cache implementation to operations/cache#7012
Open
Move global_cache implementation to operations/cache#7012
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7012 +/- ##
==========================================
+ Coverage 69.04% 69.15% +0.10%
==========================================
Files 380 382 +2
Lines 66860 67071 +211
==========================================
+ Hits 46166 46384 +218
+ Misses 20694 20687 -7 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
tenstorrent/tt-xla#922
Problem description
tt-xla manylinux build fails because of circular dependency between global cache and load cache
What's changed
Different versions of build tools and environment causes more rigid check.
Load cache is inside TTNNOps lib while global cache singleton is in parent lib TTNN, and load cache uses global cache.
The problem is in linking, probably in resolving statics for singleton.
Solution is to move global cache into TTNNOps (operations/cache).
Checklist