feat: add footer visibility toggle with localStorage persistence#548
feat: add footer visibility toggle with localStorage persistence#548NeerajPise wants to merge 7 commits intotenstorrent:devfrom
Conversation
|
@NeerajPise : could you resolve the conflicts , and I can get started reviewing this PR |
There was a problem hiding this comment.
Pull request overview
This PR adds a user-controlled footer visibility toggle feature with localStorage persistence, enabling users to show or hide the footer component. The visibility state is remembered across page reloads and navigation. The implementation replaces the previous deployment-based footer visibility logic with a more flexible user-controlled approach.
Changes:
- Introduced a new FooterVisibilityContext with provider and custom hook for state management
- Added chevron toggle buttons (up/down) to the Footer component for showing/hiding functionality
- Removed the deployment-based footer conditional rendering from MainLayout
- Integrated the FooterVisibilityProvider into the App component hierarchy
- Applied formatting fixes (removed trailing spaces in bug report template, changed
lettoconst)
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| app/frontend/src/contexts/FooterVisibilityContext.ts | Defines the FooterVisibilityContext type and creates the context |
| app/frontend/src/providers/FooterVisibilityContext.tsx | Implements the provider with localStorage persistence and default visibility logic |
| app/frontend/src/hooks/useFooterVisibility.ts | Custom hook for consuming the FooterVisibilityContext with error handling |
| app/frontend/src/App.tsx | Wraps the app in FooterVisibilityProvider to enable context throughout the app |
| app/frontend/src/layouts/MainLayout.tsx | Removes deployment-based footer hiding logic, always renders Footer component |
| app/frontend/src/components/Footer.tsx | Adds toggle buttons, AnimatePresence wrapper, and visibility state handling |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@anirudTT I'll resolve the conflicts and update the PR after checking Copilot's suggested fixes soon |
01af141 to
5f9592f
Compare
5f9592f to
699939f
Compare
|
@anirudTT Fixed the conflicts and integrated Copilot's suggestions after a review |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This PR implements a user-controlled footer visibility toggle system, allowing users to show/hide the footer. The visibility state persists across page reloads using localStorage.
This solves #493
Functional testing -
Theme Testing -
Visual Testing -
Demo video -
Screen.Recording.2025-11-20.at.9.35.00.PM.mp4