fix: replace deprecated Lucide GitHub icon with official logo#549
fix: replace deprecated Lucide GitHub icon with official logo#549NeerajPise wants to merge 4 commits intotenstorrent:devfrom
Conversation
NeerajPise
force-pushed
the
dev-neeraj/541-replace-deprecated-github-icon
branch
from
5c5f575 to
f97d8f8
Compare
There was a problem hiding this comment.
Pull request overview
Replaces the deprecated Github Lucide icon usage in the frontend footer UI with the official GitHub mark rendered as inline SVG, to avoid future breakage and comply with GitHub branding requirements.
Changes:
- Removed deprecated
Githubimport fromlucide-react. - Replaced GitHub icon usages in the footer and TT Studio information modal with inline SVG.
- Added theme-aware fill color logic for the inline SVG.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| <path | ||
| fillRule="evenodd" | ||
| clipRule="evenodd" | ||
| d="M48.854 0C21.839 0 0 22 0 49.217c0 21.756 13.993 40.172 33.405 46.69 2.427.49 3.316-1.059 3.316-2.362 0-1.141-.08-5.052-.08-9.127-13.59 2.934-16.42-5.867-16.42-5.867-2.184-5.704-5.42-7.17-5.42-7.17-4.448-3.015.324-3.015.324-3.015 4.934.326 7.523 5.052 7.523 5.052 4.367 7.496 11.404 5.378 14.235 4.074.404-3.178 1.699-5.378 3.074-6.6-10.839-1.141-22.243-5.378-22.243-24.283 0-5.378 1.94-9.778 5.014-13.2-.485-1.222-2.184-6.275.486-13.038 0 0 4.125-1.304 13.426 5.052a46.97 46.97 0 0 1 12.214-1.63c4.125 0 8.33.571 12.213 1.63 9.302-6.356 13.427-5.052 13.427-5.052 2.67 6.763.97 11.816.485 13.038 3.155 3.422 5.015 7.822 5.015 13.2 0 18.905-11.404 23.06-22.324 24.283 1.78 1.548 3.316 4.481 3.316 9.126 0 6.6-.08 11.897-.08 13.526 0 1.304.89 2.853 3.316 2.364 19.412-6.52 33.405-24.935 33.405-46.691C97.707 22 75.788 0 48.854 0z" | ||
| fill={theme === "dark" ? "#fff" : "#24292f"} | ||
| /> |
There was a problem hiding this comment.
In the modal button, the SVG fill color is also derived from theme === "dark", which won’t track the actual rendered mode when theme is "system". Prefer dark:-based CSS/Tailwind fill classes (or a shared icon component) so the icon color always matches the active color scheme.
There was a problem hiding this comment.
There's no way for the user to set the theme as "system" right now through the UI. However, this can be done by manually editing the local storage, which might be an edge case.
@anirudTT Do we want to handle this? If so, this might need to be a different issue, as 84 instances of this exist across the codebase
2 participants
Changes
Githubicon from lucide-react with inline SVG implementation#24292f(dark gray) for light mode,#ffffor dark modeGithubimport from lucide-reactThis solves #541. Official GitHub icons obtained from https://github.com/logos
Mockups