fix: firefox mic access error for SR modal#556
Open
AnkittChauhan wants to merge 11 commits intotenstorrent:devfrom
Open
fix: firefox mic access error for SR modal#556AnkittChauhan wants to merge 11 commits intotenstorrent:devfrom
AnkittChauhan wants to merge 11 commits intotenstorrent:devfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes microphone access issues in Firefox by removing hardcoded sample rate constraints from the audio recording configuration. The fix allows browsers to use their native audio settings during recording, with resampling to the required 16kHz happening later in the audio conversion pipeline.
Key Changes:
- Removed hardcoded 16kHz sample rate constraint from
getUserMediacall - Removed hardcoded sample rate from
AudioContextinitialization - Maintained existing resampling logic in
waveConverter.tsto ensure consistent 16kHz output
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Add copyright notice for shadcn to the file.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
app/frontend/src/components/speechToText/AudioRecorderWithVisualizer.tsx
Outdated
Show resolved
Hide resolved
…alizer.tsx Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Fixes the
mic/speech-to-textissue on Firefox browsers by removing the hardcoded sampleRate and allowing the browser to use its default audio configurationFixes #317
517830063-e74bdc0a-d5e4-4afd-91dc-ae3591108fb1.mov