drivers: sensor: tenstorrent: pvt: refactor driver#877
drivers: sensor: tenstorrent: pvt: refactor driver#877alexapostolu wants to merge 2 commits intotenstorrent:mainfrom
Conversation
|
@afongTT Just confirming, is 75 a reasonable max limit for the temperature test? There's at least two CI runs now that have the chip temperature at 71 C |
|
I've seen a bunch of tests where it's failing at close to zero degrees (at least according to logs), so well outside of the In this case, it's on https://github.com/tenstorrent/tt-zephyr-platforms/actions/runs/19913215921/job/57086440153 |
|
@cfriedt I'll take another look at the PVT driver to see if there's a bug in the implementation |
|
@alexapostolu - are we is not floating point in Pvt? |
|
@cfriedt We're not using the float type directly but we are still representing the decimal place using |
Yeah, I think increasing the max to 75 or 80 would be reasonable. But the 0 degree reading isn't right. |
e6b12d3 to
fa56728
Compare
4a6dc23 to
8606b69
Compare
|
I don't think this PR can be merged anytime soon. To merge it, then we either have to add functions just for converting between raw sensor value to telemetry value and vice versa (which would be redundant), or change the arc message format (with won't be until the next major version upgrade). |
Increase maximum temperature allowed in tests to 75 celcius. This is because a failure has been observed on at least two runs where the temperature reached 71 celcius. So increase it to 75 to be safe, and 75 is still a reasonable temperature for the chip. Signed-off-by: Alex Apostolu <aapostolu@tenstorrent.com>
* Basic refactoring * Remove streaming implementation * Use raw value instead of the deprecated sensor_value * Remove sensor_value conversion functions Signed-off-by: Alex Apostolu <aapostolu@tenstorrent.com>
Refactor the PVT driver. There's been some CI failures where temperature readings have been outside the
[40, 70]range.The readings beyond
70are no more than71, so we increase the max to75.The readings below
40hover near0. I can't reproduce it, but I suspect this might be a data conversion issue. I refactored the PVT driver to have less data conversions, to use q31_t instead of float, and just basic refactoring to make the code simpler.