subsys: logging: add a virtual console logger#955
Open
danieldegrasse wants to merge 2 commits intotenstorrent:mainfrom
Open
subsys: logging: add a virtual console logger#955danieldegrasse wants to merge 2 commits intotenstorrent:mainfrom
danieldegrasse wants to merge 2 commits intotenstorrent:mainfrom
Conversation
danieldegrasse
force-pushed
the
feature/tt-virt-console
branch
2 times, most recently
from
01cb6b1 to
3916ec7
Compare
jgrowdenTT
reviewed
Jan 16, 2026
jgrowdenTT
previously approved these changes
Jan 16, 2026
alexapostolu
previously approved these changes
Feb 4, 2026
Member
|
@danieldegrasse Could you add a note in the release notes for this? |
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Member
|
@danieldegrasse Grendel build test seemed to fail when I try to send this to the merge queue? |
Contributor
Author
Let me rebase, to get this to rekick tests |
danieldegrasse
force-pushed
the
feature/tt-virt-console
branch
from
3916ec7 to
8d6ccc7
Compare
Add a virtual console logger, which enables us to view logs in simulation Signed-off-by: Daniel DeGrasse <ddegrasse@tenstorrent.com>
Enable logging with virtual console on the grendel SMC Signed-off-by: Daniel DeGrasse <ddegrasse@tenstorrent.com>
danieldegrasse
dismissed stale reviews from jgrowdenTT and alexapostolu
via
56d6454
danieldegrasse
force-pushed
the
feature/tt-virt-console
branch
from
8d6ccc7 to
56d6454
Compare
Contributor
Author
Added |
alexapostolu
previously approved these changes
Feb 12, 2026
Member
|
I'll merge after 19.6.0 |
danieldegrasse
force-pushed
the
feature/tt-virt-console
branch
from
1ba13d4 to
56d6454
Compare
Contributor
Author
Sure- dropped the release notes entry |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a virtual console logger. This logger is useful on Grendel simulation platforms