Conversation
alayander
force-pushed
the
recovery-image-ci-test
branch
7 times, most recently
from
1a96c09 to
591697e
Compare
|
@danieldegrasse @afongTT requesting reviews for this PR |
|
Regarding naming, would it be better to rename this test as fallback image instead of recovery image? This way there won't be as much confusion with the recovery process |
app/smc/pytest/recovery.py
Outdated
| return ansi_escape.sub("", s) | ||
|
|
||
|
|
||
| try: |
There was a problem hiding this comment.
Can you import this code from e2e-smoke.py instead?
Alternatively if we need a better home for this, feel free to make a new py file that smoke/stress/recovery use.
| rm -rf $ZEPHYR_BASE/build-dmc | ||
| fi | ||
|
|
||
| if [[ "$TEST_SET" == *"recovery-flash"* ]]; then |
There was a problem hiding this comment.
Feels like this call could be made on line 86 with a logical OR of some sort on the condition on 84. Tag and outdir changes so be mindful of that.
Copy pasting this huge string for each different type of test suite I want to run seems like overkill.
(But maybe I should log this complaint with twister itself.)
alayander
force-pushed
the
recovery-image-ci-test
branch
from
591697e to
57bb6d7
Compare
Fix test for verifying recovery image functionality to match build output and tt_boot_fs. The test now properly boots into recovery image after attempting to load corrupted main image and flashes back regular firmware and works on multi-chip boards. Signed-off-by: Alexander Lay <alexanderlay@tenstorrent.com>
Adds twister command to call recovery-flash test in e2e test script. Signed-off-by: Alexander Lay <alexanderlay@tenstorrent.com>
alayander
force-pushed
the
recovery-image-ci-test
branch
2 times, most recently
from
84756be to
cc2d06d
Compare
2 participants
Adds a e2e test to validates booting into recovery CMFW.