V1 support for remaining sampling parameters#307
Merged
Conversation
tchedaTT
requested review from
ppetrovicTT,
skhorasganiTT and
viktorpusTT
as code owners
tchedaTT
force-pushed
the
tcheda/v1_sampling_generality
branch
from
73d1015 to
f689d08
Compare
Author
tchedaTT
force-pushed
the
tcheda/v1_sampling_generality
branch
from
2601742 to
04f47df
Compare
… to ttsamplingparams
…nly sampling params
tchedaTT
force-pushed
the
tcheda/v1_sampling_generality
branch
from
04f47df to
d441413
Compare
Author
|
previous run had multiple unrelated failures, new one: https://github.com/tenstorrent/tt-metal/actions/runs/21996024453 |
skhorasganiTT
approved these changes
Feb 13, 2026
| model_input) | ||
| sampled_token_ids = sampled_token_ids_per_dp[0] | ||
| logprobs_tensors = logprobs_per_dp[0] if logprobs_per_dp else None | ||
| logprobs = logprobs_tensors.tolists() if logprobs_tensors else None |
Collaborator
There was a problem hiding this comment.
is the tolists() needed here?
Author
There was a problem hiding this comment.
This is here to match the conversion done in the DP path, which in turn is there to match what the gpu_model_runner does. It might be cleaner to do it in get_output_tokens and investigate whether it can be removed, but I think that's best handled in a separate PR.
This was referenced Feb 13, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Implement the changes from #301
Custom logits processors are not currently supported - this is a limitation of the v1 version we branched from. More changes possibly required once we rebase onto a version of v1 that supports them
Test Plan
Added tests covering these sampling features, testing across DP/non DP correct so far. CI pipeline to run them across all machine/model combos WIP.