Adds Rails 6.1 if_exists flags#165
Closed
humphreyja wants to merge 4 commits intoteoljungberg:masterfrom
Closed
Conversation
Owner
|
Great addition - I'm in favor. I'll circle back to this in a few days. For context - this was introduced as rails/rails#38352 in 6.1 |
Owner
|
The standardrb warnings is something I'd like to see get dealt with in this PR. I'll continue with refactoring once this is merged as I have some stylistic ideas that aren't on you as the contributor to deal with. |
Owner
|
Not having heard back for a while - I'm closing this. Feel free to open an issue or another PR to add support for this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rails 6.1 added
if_existsflags to things likeremove_columnto assist with edge cases of migrations where the column was removed and possibly not readded in a rollback; basically putting your entire migration in a state of failure. Just ran across this with this gem, so this seems like a good addition.Blog post showing how the
if_existsflag works.https://blog.saeloun.com/2020/02/10/rails-support-for-if-exists-if-not-exists-on-remove-column-add-column-in-migrations