Extract validation methods in Statements module#184
Merged
teoljungberg merged 4 commits intomasterfrom Dec 11, 2025
Merged
Conversation
Refactor the Statements module to reduce code duplication and improve maintainability by extracting repeated validation and SQL resolution logic. Changes: - Extract error message constants: * VERSION_OR_SQL_DEFINITION_REQUIRED * VERSION_AND_SQL_DEFINITION_EXCLUSIVE - Extract validation methods: * validate_version_or_sql_definition_present! * validate_version_and_sql_definition_exclusive! - Extract resolve_sql_definition method to handle SQL definition resolution - Apply extracted methods across create_function, update_function, create_trigger, and update_trigger - Simplify conditional logic (e.g., version ||= 1 instead of if/nil check) - Remove unused _on variable in create_trigger Benefits: - DRY: Validation logic defined once, used in multiple places - Consistency: Same validation behavior across all methods - Maintainability: Changes to validation logic only need to happen in one place - Testability: Private methods can be tested independently if needed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor the Statements module to reduce code duplication and improve
maintainability by extracting repeated validation and SQL resolution logic.
Changes:
resolve_sql_definitionmethod to handle SQL definition resolutionversion ||= 1instead of if/nil check)_onvariable increate_trigger