Refactor Statements to use explicit keyword arguments#186
Open
teoljungberg wants to merge 7 commits intomasterfrom
Open
Refactor Statements to use explicit keyword arguments#186teoljungberg wants to merge 7 commits intomasterfrom
teoljungberg wants to merge 7 commits intomasterfrom
Conversation
teoljungberg
force-pushed
the
opts-to-kwargs
branch
from
de68a76 to
1b68b1a
Compare
Changes: - `Statements`: Use explicit keyword arguments `(version:, sql_definition:, ...)` - `CommandRecorder`: Add `ruby2_keywords` markers for proper forwarding - CommandRecorder::Arguments: Use Hash.ruby2_keywords_hash for revert options The `ruby2_keywords` approach ensures keyword arguments are properly preserved when `CommandRecorder` replays migrations via `send(*args)`.
teoljungberg
force-pushed
the
opts-to-kwargs
branch
from
4cf5c34 to
3386bca
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
(version:, sql_definition:, ...)over(options = {})ruby2_keywordsmarkers for proper forwardingThe
ruby2_keywordsapproach ensures keyword arguments are properlypreserved when
Fx::CommandRecorderreplays migrations viasend(*args).