Skip to content

Use methods over instance variables #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
teoljungberg merged 2 commits into from
Dec 20, 2025
Merged

Use methods over instance variables #192

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f2f5f80
Use methods over instance variables
teoljungberg Dec 19, 2025
5a7ef0b
Merge branch 'master' into attrs
teoljungberg Dec 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions lib/fx/command_recorder.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ def initialize(args)
end

def function
@args[0]
args[0]
end

def version
Expand All @@ -84,13 +84,15 @@ def invert_version
end

def to_a
@args.to_a
args.to_a
end

private

attr_reader :args

def options
@options ||= @args[1] || {}
@options ||= args[1] || {}
end

def options_for_revert
Expand Down
12 changes: 7 additions & 5 deletions lib/fx/definition.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,13 +14,13 @@ def self.trigger(name:, version:)

def initialize(name:, version:, type:)
@name = name
@version = version.to_i
@version_number = version.to_i
@type = type
end

def to_sql
content = File.read(find_file || full_path)
raise "Define #{@type} in #{path} before migrating." if content.empty?
raise "Define #{type} in #{path} before migrating." if content.empty?

content
end
Expand All @@ -30,17 +30,19 @@ def full_path
end

def path
@_path ||= File.join("db", @type.pluralize, filename)
@_path ||= File.join("db", type.pluralize, filename)
end

def version
@version.to_s.rjust(2, "0")
version_number.to_s.rjust(2, "0")
end

private

attr_reader :name, :version_number, :type

def filename
@_filename ||= "#{@name}_v#{version}.sql"
@_filename ||= "#{name}_v#{version}.sql"
end

def find_file
Expand Down