Angular2+ by kortemik · Pull Request #532 · teragrep/ajs_01

kortemik · 2026-05-20T10:48:49Z

Description

Checklists

Testing

General

I have checked that my test files and functions have meaningful names.
I have checked that each test tests only a single behavior.
I have done happy tests.
I have tested only my own code.
I have tested at least all public methods.

Assertions

I have checked that my tests use assertions and not runtime overhead.
I have checked that my tests end in assertions.
I have checked that there is no comparison statements in assertions.
I have checked that assertions are in tests and not in helper functions.
I have checked that assertions for iterables are outside of for loops and both sides of the iteration blocks.
I have checked that assertions are not tested inside consumers.

Testing Data

I have tested algorithms and anything else with the possibility of unbound growth.
I have checked that all testing data is local and fully replaceable or reproducible or both.
I have checked that all test files are standalone.
I have checked that all test-specific fake objects and classes are in the test directory.
I have checked that my tests do not contain anything related to customers, infrastructure or users.
I have checked that my tests do not contain non-generic information.
I have checked that my tests do not do external requests and are not privately or publicly routable.

Statements

I have checked that my tests do not use throws for exceptions.
I have checked that my tests do not use try-catch statements.
I have checked that my tests do not use if-else statements.

Java

I have checked that my tests for Java uses JUnit library.
I have checked that my tests for Java uses JUnit utilities for parameters.

Other

I have only tested public behavior and not private implementation details.
I have checked that my tests are not (partially) commented out.
I have checked that hand-crafted variables in assertions are used accordingly.
I have tested Object Equality.
I have checked that I do not have any manual tests or I have a valid reason for them and I have explained it in the PR description.

Code Quality

I have checked that my code follows metrics set in Procedure: Class Metrics.
I have checked that my code follows metrics set in Procedure: Method Metrics.
I have checked that my code follows metrics set in Procedure: Object Quality.
I have checked that my code does not have any NULL values.
I have checked my code does not contain FIXME or TODO comments.

Co-authored-by: sryhanen <samuli.ryhanen@fail.safe.net>

* Squashed Issue-469 * Issue 505/html output (#2) * HtmlPlugin object * HtmlFormat object * Angular view for html plugin * Add html format to object tree * Small fixes * Remove css class --------- Co-authored-by: sryhanen <samuli.ryhanen@fail.safe.net> * Fixed tests --------- Co-authored-by: sryhanen <samuli.ryhanen@fail.safe.net>

* Updated testing library to compatible version with angular19+ * Added safeJson object for handling json data * Paragraph collection object * Refactored notebook responsibilities * Refactored notebookCollection responsibilities * Refactored paragraph responsibilities * Added message object * Removed DTO objects and added message handlers * Refactored outputContainer responsibilities * Refactored outputPlugin and outputFormat responsibilities * OutputFormat implementations refactored * OutputPlugin implementations refactored * OutputSwitcher implementation refactored * AngularObjectCollection responsibilities refactored * Added more message handlers * Removed obsolete files and refactored after removing DTOs * Refactored angular components, separated angular logic from business logic * Refactored legacy websocket messages to comply with basic message format * Required changes to devserver after refactoring * Refactored OutputContainer to hold the responsibility for active plugin * Updated tests --------- Co-authored-by: sryhanen <samuli.ryhanen@fail.safe.net>

sryhanen · 2026-05-21T07:50:14Z

One enhancement I've been thinking, would be refactor the directory structure for new code:

- ./app/objects should contain only the business logic, i.e. the object code
- ./app/html ( 'html' or something similar) should hold everything related for rendering the UI
- ./app/html/angular2+ contains logic for modern angular implementations
- ./app/html/angularJs contains logic for legacyAjs implementations required to keep

@kortemik @eemhu
Any thoughts on this, and should it be implemented?

* Directive for rendering outputView programmatically * Refactored OutputView rendering from outputContainer * Modern input signals seem not to be entirely supported in a hybrid application, replaced input signal with traditional input decorator * Added fakePlugin for testing * Renamed input name * Fixed and refactored test * Added test file for pluginView * Add license --------- Co-authored-by: sryhanen <samuli.ryhanen@fail.safe.net>

sryhanen · 2026-05-25T08:59:31Z

Started implementing #535 for this

eemhu · 2026-05-26T07:11:14Z

One enhancement I've been thinking, would be refactor the directory structure for new code:
* * ` ./app/objects`  should contain only the business logic, i.e. the object code

* * ` ./app/html` ( 'html' or something similar) should hold everything related for rendering the UI

* * ` ./app/html/angular2+` contains logic for modern angular implementations

* * ` ./app/html/angularJs` contains logic for legacyAjs implementations required to keep
@kortemik @eemhu Any thoughts on this, and should it be implemented?

sounds like a decent idea, perhaps html could be named ui though

sryhanen · 2026-05-26T07:39:59Z

One enhancement I've been thinking, would be refactor the directory structure for new code:
* * ` ./app/objects`  should contain only the business logic, i.e. the object code

* * ` ./app/html` ( 'html' or something similar) should hold everything related for rendering the UI

* * ` ./app/html/angular2+` contains logic for modern angular implementations

* * ` ./app/html/angularJs` contains logic for legacyAjs implementations required to keep
@kortemik @eemhu Any thoughts on this, and should it be implemented?
sounds like a decent idea, perhaps html could be named ui though

Started working on this:
#548

sryhanen · 2026-05-26T07:40:52Z

Started implementing #535 for this

#547

* NotebookCollection integration test, and fixes for notebookCollection * WritableSignalArrayAsPushValue object for handling values with list type * Renamed unit tests with .unit prefix * ParagraphCollection object * Refactored paragraph rendering to ParagraphCollectionView * NotebookView integration spec * ParagraphCollectionView integration tests * ParagraphView integration tests * OutputContainerView integration spec * Renamed spec files --------- Co-authored-by: sryhanen <samuli.ryhanen@fail.safe.net>

Co-authored-by: sryhanen <samuli.ryhanen@fail.safe.net>

sryhanen · 2026-05-27T13:04:04Z

Problems detected during qa testing fixed in pr #555

* Fixed angular output format parsing * Render only current notebook in collection if id matches * ad hoc fix for broken output data format * Fixed Ajs template input name * Link paragraphCollection to angularObject collection so that on request paragraphCollection can decorate requests * Text plugin needs to add class value to html element * Pass responses to angularObjectCollection * Log error instead of warning * ParagraphCollection refactored as stubable, due notebook being partial initially * Updated notebook spec * Added tests for paragraphCollection * Re-use variable --------- Co-authored-by: sryhanen <samuli.ryhanen@fail.safe.net>

* Refactored paragraphCollection as property of paragraph, because paragraph is responsible for filtering messages that paragraphCollection receives * Logic for handling paragraphId was missing from angular object, refactored object to encapsulate paragraphId --------- Co-authored-by: sryhanen <samuli.ryhanen@fail.safe.net>

eemhu · 2026-06-02T08:00:18Z

+ * a licensee so wish it.
+ */
 /*
 * Licensed under the Apache License, Version 2.0 (the 'License');


the file appears to have two licenses

eemhu · 2026-06-02T08:21:26Z

    spyOn(scope, 'updateParagraphObjectWhenUpdated');
    spyOn(scope, 'updateAllScopeTexts');
-    scope.updateParagraph(paragraphExampleMock.paragraph, paragraphClearMock.paragraph, emptyCallback);
+    scope.updateParagraph(paragraphExampleMock.paragraph, paragraphClearMock.paragraph);


wasn't the paragraph object removed? from paragraphExampleMock

* Refactored encapsulate properties of angularObject * Refactored angularObjectCollection initialization to paragraph object * Changed test description --------- Co-authored-by: sryhanen <samuli.ryhanen@fail.safe.net>

eemhu · 2026-06-03T06:40:51Z

+  }
+
+  value(): unknown {
+    return this._angularObjectData['object'];


any reason to not use the SafeJson object? this way the non-validated object could be removed as a field variable and only have the SafeJson variant.

Perhaps SafeJson could be renamed as a ValidatedObject or such.

eemhu · 2026-06-04T12:02:09Z

+export class AngularObjectCollectionImpl implements AngularObjectCollection {
+  private readonly _channel: Channel;
+  private readonly _angularObjects: AngularObject[];
+  private readonly _pushValues: PushValue<AngularObject[]>[];


I don't think I fully understand the purpose of the PushValue object, could you explain a bit?

eemhu · 2026-06-04T12:40:23Z

+ */
+
+export interface MessageWithAuthenticationInfo {
+  print(): {


would message() be more descriptive here

eemhu · 2026-06-04T12:44:27Z

+      ticket: '',
+      roles: '',
+    };
+    if(!this._authentication.isStub()){


I would leave authenticationInfo undefined and define it in else-block if authentication.isStub=false.

eemhu · 2026-06-05T06:25:19Z

+      expect(angularObjectCollection).toBeInstanceOf(AngularObjectCollectionImpl);
+    });
+
+    it('Should have empty collection of angular objects', () => {


non-empty test?

eemhu · 2026-06-05T09:00:51Z

+      outputContainer.request(request);
+      expect(channelSpy).toHaveBeenCalledExactlyOnceWith(request);
+    });
+  });


Should we also test response here

eemhu · 2026-06-05T09:22:41Z

+  });
+
+  describe('Plugin formatting', () => {
+    const plugingData = {


* Added missing webpackplugin for loading angular templates properly * Add AngularWebpackPlugin to production webpack config as well * This causes now type error * Now input signals work * Exclude unused files * POC solution for refactor * Fix recursion pattern from Render and RenderNode * poc version 2 * use signals for component inputs as well * Recursive component rendering * Stash * Poc works now * small fix * Refactored directories * ComponentView object * ParagraphCollectionRefactored * OutputContainer refactored * Output render works almost now, expect inputs are not updated since they are not wrapped to signals * Fixed signal read for RecursiveComponentDraw * Updated stub outputPlugin * webAppRoot needs to print signal and update it each response * Can use computed signal here instead of effect * Fix bug where adding paragraph caused disorientation of the paragraph mapping * This is not part of the objects responsibilities * Started refactoring OutputFormats * uPlot refactored * Renamed method * textOutput * AngularFormat * Deleted unused files * Removed WebAppComponentRegistry since it caused unnecessary complexity * Refactored outputPlugins, removed unused ones * Deleted unused file * Started refactoring outputSwitcher * Switcher refactored * Ad hoc fix for uPlotView change detection * Refactored outputFormat validation and conditional switching to separate object * Override inherited exclude rule for spec config * Fixed tests * Fixed tests * Fixed tests * Fixed tests * Fixed tests * Fixed tests * Fixed tests * Fixed tests * Subtyped OutputFormat objects * Fixed tests * Fixed tests * Added test * Fixed tests * Added test * Refactored NotebookCollection * Updated tests * ParagraphCollection is no longer stubable * Added test * Implemented generic filter object * Refactored paragraphOutputMessage as stubable * ParagraphDataAsOutputMessage object * Initialize decorator paragraph collection * Deleted push value objects * Patched tests * Core idea of the response refactor * Deleted obsolete objects * Decorator ResponseRegister objects * Refactor to use ResponseRegister * ParagraphMessage object * ParagraphAddedMessage * ParagraphRemovedMessage object * Refactored ParagraphCollection * Added RequestRegister object * Refactored paragraphCollection * Added unit test * fixed RequestRegister implementation * RequestRegisterWithPropertyDecorator object * Fixed implementations * Refactored interpreterErrorListener * Fixed tests * fixed test * removed signal * fixed tests * fixed tests * fixed tests * Refactored ParagraphOutputMessage * Refactored ParagraphOutputMessage * Fixed test * Refactored OutputFormat SwitcherButtons property * Fixed tests * Added test * Fixed test * Fixed tests * Added and fixed tests * Fixed test * Added test * Fixed implementation and test * Added test * Added test * Added testing library plugin for asserting changes for components who rely on css. Bootstrap5 modal for instance is such component. * Added test file * Added host class * Added test * Added tests * Added tests * Added tests * Added tests * Added test * Added test * Karma unit tests require additional webpack config that uses ts-loader --------- Co-authored-by: sryhanen <samuli.ryhanen@fail.safe.net>

…ion (#581) Co-authored-by: sryhanen <samuli.ryhanen@fail.safe.net>

eemhu · 2026-06-30T13:02:46Z

+
+    it('Should have notebookIndices', () => {
+      expect(notesInfoMessage.notebookIndices().size).toEqual(2);
+      expect(notesInfoMessage.notebookIndices().get('notebook1')).toBeDefined();


would assert the actual indices

eemhu · 2026-07-01T09:19:04Z

+
+  private validateType():void{
+    if(this._type !== this._message.operation()){
+      throw new RangeError(`Message type is not "${this._type}".`);


would be worth to have the expected and actual message type in the error message

eemhu · 2026-07-01T13:08:21Z

+      const paragraphOutputMessage = new ParagraphOutputMessageImpl(message);
+      if(paragraphOutputMessage.type() !== OutputType.angular){
+        this._componentView.set(this._componentViewStub);
+        return;


use else block instead of early return

eemhu · 2026-07-02T10:14:41Z

+      if(paragraphOutputMessage.type() !== OutputType.dataTables){
+        this._componentView.set(this._componentViewStub);
+        this._plugin.set(this._pluginStub);
+        return;


replace early return with else block

eemhu · 2026-07-02T13:23:12Z

+      const paragraphOutputMessage = new ParagraphOutputMessageImpl(message);
+      if(paragraphOutputMessage.type() !== OutputType.html) {
+        this._componentView.set(this._componentViewStub);
+        return;


replace with else block

eemhu · 2026-07-03T07:18:13Z

+import {RgbColor} from './rgbColor';
+
+export class RgbColorImpl implements RgbColor {
+  private readonly _red:number;


Could be improved with RgbaColor decorator. But perhaps leave that for another PR.

RgbColor(red, green, blue)
RgbaColor(RgbColor, opacity)

eemhu · 2026-07-03T10:42:43Z

+    const uPlotOutputOptions = {
+      labels:safeOutputOptions.getProperty<string[]>('labels', 'object'),
+      series:safeOutputOptions.getProperty<string[]>('series', 'object'),
+      xAxisLabel:safeOutputOptions.getProperty<string>('xAxisLabel', 'string'),
+      graphType: safeOutputOptions.getProperty<string>('graphType', 'string'),
+    };
+    let uPlotOptions:uPlot.Options;
+    const basicOptions = new BasicOptionsImpl(uPlotOutputOptions);


I feel like this could be part of the BasicOptions object

eemhu · 2026-07-03T12:55:51Z

+import {ComponentView} from '../../rendering/componentView/componentView';
+import {OutputFormatsWithValidatedOutputSwitch} from './outputFormatsWithValidatedOutputSwitch';
+
+export class OutputFormatsWithValidatedOutputSwitchImpl implements OutputFormatsWithValidatedOutputSwitch {


Not really clear on the purpose of this object. At least the name could use a fix

eemhu · 2026-07-03T13:16:31Z

+import {ParagraphOutputMessageImpl} from '../../message/paragraphOutputMessage/paragraphOutputMessageImpl';
+import {MessageImpl} from '../../message/messageImpl';
+
+export class ParagraphDataAsOutputMessageImpl implements ParagraphDataAsOutputMessage {


ParagraphOutputMessageFactory

eemhu · 2026-07-03T13:21:07Z

+
+    const paragraphDataAsOutputMessage = new ParagraphDataAsOutputMessageImpl(paragraph);
+    const paragraphOutputMessage = paragraphDataAsOutputMessage.paragraphOutputMessage();
+    if(!paragraphOutputMessage.isStub()){


way to clean up ctor?

sryhanen and others added 3 commits May 19, 2026 16:12

Squashed Issue-461 (#515)

69c2e46

Co-authored-by: sryhanen <samuli.ryhanen@fail.safe.net>

kortemik requested a review from eemhu May 20, 2026 10:48

sryhanen mentioned this pull request May 26, 2026

Refactor directory structure #548

Closed

sryhanen and others added 2 commits May 27, 2026 10:50

Refactored directory structure (#554)

d8777ee

Co-authored-by: sryhanen <samuli.ryhanen@fail.safe.net>

sryhanen and others added 2 commits May 29, 2026 13:02

eemhu reviewed Jun 2, 2026

View reviewed changes

Angular objects with unique paragraphs (#559)

b240034

* Refactored encapsulate properties of angularObject * Refactored angularObjectCollection initialization to paragraph object * Changed test description --------- Co-authored-by: sryhanen <samuli.ryhanen@fail.safe.net>

eemhu reviewed Jun 3, 2026

View reviewed changes

eemhu reviewed Jun 4, 2026

View reviewed changes

eemhu reviewed Jun 5, 2026

View reviewed changes

sryhanen mentioned this pull request Jun 11, 2026

Refactor to signal-based rendering logic #564

Open

kortemik requested a review from eemhu June 26, 2026 07:38

Exclude webpack config for karma test runner from typescript compilat…

d3320ea

…ion (#581) Co-authored-by: sryhanen <samuli.ryhanen@fail.safe.net>

eemhu reviewed Jun 30, 2026

View reviewed changes

eemhu reviewed Jul 1, 2026

View reviewed changes

eemhu reviewed Jul 2, 2026

View reviewed changes

eemhu reviewed Jul 3, 2026

View reviewed changes

Uh oh!

Conversation

kortemik commented May 20, 2026

Description

Checklists

Testing

General

Assertions

Testing Data

Statements

Java

Other

Code Quality

Uh oh!

sryhanen commented May 21, 2026

Uh oh!

sryhanen commented May 25, 2026

Uh oh!

eemhu commented May 26, 2026

Uh oh!

sryhanen commented May 26, 2026

Uh oh!

sryhanen commented May 26, 2026

Uh oh!

sryhanen commented May 27, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants