Revise environment variables and bindings for different image types#685
Merged
Conversation
Apply image manifest Env in every mode (isolated, minimal, and termux-type containers, which previously ignored it). Inherit Android host vars only in the default mode (Termux, neither isolated nor minimal); factor the var list into a shared ANDROID_HOST_ENV_VARS. Termux-type containers no longer bind the host's /data/data/com.termux or shared storage: non-isolated binds only Android system directories, isolated/minimal binds no host directories. Normal-type bindings are unchanged.
Shared storage (/storage, /sdcard) is host-domain Android storage, not the per-distro /data/data/com.termux, so it should be visible to both distro types in the default mode. Only the Termux app data binds stay normal-type-only.
Split the Android data binds: /data/app, /data/dalvik-cache and /data/misc/apexdata/com.android.art/dalvik-cache are Android-system caches (not the Termux app's private data), so both distro types get them in the default mode. The Termux app dirs (apps, cache, $HOME) under /data/data/com.termux stay normal-type-only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.