-
Notifications
You must be signed in to change notification settings - Fork 359
Clipboard features #205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
thunder-coding
wants to merge
2
commits into
termux:master
Choose a base branch
from
thunder-coding:clipboard-features
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Clipboard features #205
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
[*] | ||
trim_trailing_whitespace = true | ||
insert_final_newline = true | ||
|
||
[*.{c,h}] | ||
indent_style = space | ||
indent_size = 4 | ||
|
||
# There is no consistency between tab and spaces, some files are using tabs | ||
# whereas others are using spaces, but use tabs as we use it in our other | ||
# repositories | ||
[*.in] | ||
indent_style = tab | ||
indent_size = 4 | ||
|
||
[CMakeLists.txt] | ||
indent_style = space | ||
indent_size = 2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
cmake_minimum_required(VERSION 3.0.0) | ||
cmake_minimum_required(VERSION 3.25) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This change is because cmake 4 is now raising errors about older requirements for cmake version < 3.5.0. Arch has got cmake 4, so I am getting this error, we too probably will be getting update to cmake 4 for termux-packages soon |
||
project(termux-api) | ||
include(GNUInstallDirs) | ||
|
||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,26 +1,32 @@ | ||
#!@TERMUX_PREFIX@/bin/sh | ||
#!@TERMUX_PREFIX@/bin/bash | ||
set -e -u | ||
|
||
SCRIPTNAME=termux-clipboard-set | ||
show_usage () { | ||
echo "Usage: $SCRIPTNAME [text]" | ||
echo "Set the system clipboard text. The text to set is either supplied as arguments or read from stdin if no arguments are given." | ||
echo " -s/--sensitive Mark the written data as sensitive" | ||
exit 0 | ||
} | ||
|
||
while getopts :h option | ||
do | ||
case "$option" in | ||
h) show_usage;; | ||
?) echo "$SCRIPTNAME: illegal option -$OPTARG"; exit 1; | ||
esac | ||
OPT_SENSITIVE=false | ||
|
||
eval set -- "$(getopt -o hs -l sensitive,help -- "$@")" | ||
|
||
while true; do | ||
case "$1" in | ||
-s | --sensitive) OPT_SENSITIVE=true; shift 1;; | ||
-h | --help) show_usage;; | ||
--) shift; break;; | ||
esac | ||
done | ||
shift $((OPTIND-1)) | ||
|
||
CMD="@TERMUX_PREFIX@/libexec/termux-api Clipboard -e api_version 2 --ez set true" | ||
if [ "$OPT_SENSITIVE" = true ]; then | ||
CMD+=" --ez sensitive true" | ||
fi | ||
if [ $# = 0 ]; then | ||
$CMD | ||
else | ||
echo -n "$@" | $CMD | ||
fi | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this file (
.editorconfig
) be here?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this is intentional. Should make setup process for everyone easier regardless of what editor they use. Most popular editors already support editorconfig: https://editorconfig.org/#pre-installed.
Just didn't find any reason to create a separate PR for a minor change. If you want to have a separate PR, I can split it up