Clipboard features #760
Open
Clipboard features #760
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
thunder-coding
commented
Apr 3, 2025
| @@ -35,7 +37,14 @@ protected boolean trimInput() { | |||
|
|
|||
| @Override | |||
| public void writeResult(PrintWriter out) { | |||
| clipboard.setPrimaryClip(ClipData.newPlainText("", inputString)); | |||
| var clipData = ClipData.newPlainText("", inputString); | |||
There was a problem hiding this comment.
I am not familar with how you prefer to write Java, but I prefer to use implicit types where available in strictly typed languages. var should do the trick instead of having to write large classnames, or you want me to change this to maintain consistency of smell with other parts of the code?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PR termux/termux-api-package#205