Skip to content

new -I2 flag for manual off device build etc#29900

Open
john-peterson wants to merge 1 commit into
termux:masterfrom
john-peterson:dl
Open

new -I2 flag for manual off device build etc#29900
john-peterson wants to merge 1 commit into
termux:masterfrom
john-peterson:dl

Conversation

@john-peterson
Copy link
Copy Markdown
Contributor

-I will try to build dependency if you forget to update repo . this is designed for auto builds

this is for manual operation . write run git pull instead of doing something the user don't want

plus

remove gpg --verify spam when downloading many dependency files

new TERMUX_LOUD_BUILD variable

-I will try to build dependency if you forget to update repo . this is designed  for auto builds

this is for manual operation .  write run git pull instead of doing something the user don't want

plus

remove gpg --verify spam when downloading many dependency files

new TERMUX_LOUD_BUILD variable
Comment thread build-package.sh
-L) export TERMUX_GLOBAL_LIBRARY=true;;
-q) export TERMUX_QUIET_BUILD=true;;
-Q) export PS4='+$0 \[\e[32m\]${FUNCNAME[0]:-<global scope>}${FUNCNAME[*]:+()}:$LINENO\[\e[0m\] '; set -x;;
-Q) TERMUX_LOUD_BUILD=true;;
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do this change in separate commit to make the history easy to navigate

Comment thread build-package.sh
[[ "$TERMUX_ON_DEVICE_BUILD" = "false" ]] && echo " -i Download and extract dependencies instead of building them."
echo " -I Download and extract dependencies instead of building them, keep existing $TERMUX_BASE_DIR files."
echo " -I Download and extract dependencies instead of building them, keep existing $TERMUX_BASE_DIR files. build dependency if download fail [ for auto build system ]"
echo " -I2 same as -I but never build dependency [ for manual build off device ] "
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For short flags, we are only having single characters. I think having a long flag for this one would be a better choice, considering that it'll likely be used less often as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants