enhance(scripts/updates): log tag parsing failures#30034
Open
TomJo2000 wants to merge 1 commit into
Open
Conversation
TomJo2000
force-pushed
the
log-auto-update-parse-errors
branch
2 times, most recently
from
995f32a to
859fed9
Compare
TomJo2000
commented
Jun 3, 2026
Comment on lines
-18
to
-19
| # Why `--arg`? See: https://stackoverflow.com/a/54674832/15086226; `sub` strips the leading 'v' | ||
| jq -r --arg pkg "$1" '.[$pkg] // "null" | sub("^v";"")' "$TERMUX_REPOLOGY_DATA_FILE" |
Member
Author
There was a problem hiding this comment.
Since I removed the | sub("^v";"") part of the jq expression it felt appropriate to update the comment as well.
The prefix stripping is done by termux_pkg_upgrade_version.
termux-packages/scripts/updates/utils/termux_pkg_upgrade_version.sh
Lines 65 to 67 in 8f1466e
We already made the analogous change to termux_git{hub,lab}_api_get_tag in #27576 (61a53e3).
TomJo2000
force-pushed
the
log-auto-update-parse-errors
branch
from
859fed9 to
3bdf213
Compare
TomJo2000
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
That should at least give us some more insight.
Throwing in the entire
$TERMUX_REPOLOGY_DATA_FILEon a repology parse failure might be overkill, but we can filter that down once we know what the failure mode for that looks like.