feat: Added support for private hosted zone in Route53

[agustin58ruiz]

Description

main.tf
before:
data "aws_route53_zone" "this" {
count = local.create_domain_name && var.create_domain_records ? 1 : 0

name = coalesce(var.hosted_zone_name, local.stripped_domain_name)
}
now:
data "aws_route53_zone" "this" {
count = local.create_domain_name && var.create_domain_records ? 1 : 0
private_zone = var.private_zone
name = coalesce(var.hosted_zone_name, local.stripped_domain_name)
}

variables.tf
added:

line 159: variable "private_zone" {
description = "Whether the hosted zone is private or not"
type = bool
default = false
}

Motivation and Context

This is needed when someone wants to create records in a private hosted zone. The private_zone argument is required when looking up private zones using the aws_route53_zone data source. Without this parameter, Terraform cannot find the private zone, even if the zone name matches.

Breaking Changes

This change introduces a new variable (private_zone) with a default value of false, so it is backward compatible.

However, users must explicitly set private_zone = true when creating records in a private hosted zone. Failing to do so will result in the zone not being found.

How Has This Been Tested?

• I have updated at least one of the examples/* to demonstrate and validate my change(s)
• I have tested and validated these changes using one or more of the provided examples/* projects

• I have executed pre-commit run -a on my pull request

[agustin58ruiz]

I need this change for my work. I need the domain name to be created in a private zone.

[antonbabenko]

Looks good, please run pre-commit run -a on your PR and let's merge it.

[agustin58ruiz]

Hello!
I hope you're faring well.
I run pre-commit run -a and worked successfully.
Regards

[antonbabenko]

Please fix the failing checks.

[agustin58ruiz]

I added changes requested in pre-commit workflow.
These were the changes made by the terraform_wrapper_module_for_each hook in the wrappers/README.md file:

Change in the Terraform module source:

• Before: source = "tfr:///terraform-aws-modules/aws-apigatewayv2/aws//wrappers"

• After: source = "tfr:///terraform-aws-modules/apigateway-v2/aws//wrappers"
  Change in the alternative source of the Terraform module:

• Before: # source = "git::[email protected]:terraform-aws-modules/terraform-aws-aws-apigatewayv2.git//wrappers?ref=master"

• After: # source = "git::[email protected]:terraform-aws-modules/terraform-aws-apigateway-v2.git//wrappers?ref=master"
  Change in the module source in the inputs section:

• Before: source = "terraform-aws-modules/aws-apigatewayv2/aws//wrappers"

• After: source = "terraform-aws-modules/apigateway-v2/aws//wrappers"

[antonbabenko]

Why are there so many files that have been changed? Could you update the master branch to keep changes to just the required files?

[agustin58ruiz]

Close this, i won't waste more time in this.
I'll build my own module.
Regards.