feat: Add support for availability zone rebalancing (#262) #269
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
bryantbiggs
reviewed
Mar 20, 2025
main.tf
Outdated
| @@ -59,6 +59,7 @@ module "service" { | |||
| # Service | |||
| ignore_task_definition_changes = try(each.value.ignore_task_definition_changes, false) | |||
| alarms = try(each.value.alarms, {}) | |||
| availability_zone_rebalancing = try(each.value.availability_zone_rebalancing, "DISABLED") | |||
There was a problem hiding this comment.
Suggested change
| availability_zone_rebalancing = try(each.value.availability_zone_rebalancing, "DISABLED") | |
| availability_zone_rebalancing = try(each.value.availability_zone_rebalancing, null) |
bryantbiggs
reviewed
Mar 20, 2025
modules/service/variables.tf
Outdated
| @@ -39,7 +39,7 @@ variable "alarms" { | |||
| variable "availability_zone_rebalancing" { | |||
| description = " ECS automatically redistributes tasks within a service across Availability Zones (AZs) to mitigate the risk of impaired application availability due to underlying infrastructure failures and task lifecycle activities. The valid values are `ENABLED` and `DISABLED`. Defaults to `DISABLED`" | |||
| type = string | |||
| default = null | |||
| default = "DISABLED" | |||
bryantbiggs
reviewed
Mar 20, 2025
wrappers/service/main.tf
Outdated
| @@ -28,7 +28,7 @@ module "wrapper" { | |||
| } | |||
| }) | |||
| autoscaling_scheduled_actions = try(each.value.autoscaling_scheduled_actions, var.defaults.autoscaling_scheduled_actions, null) | |||
| availability_zone_rebalancing = try(each.value.availability_zone_rebalancing, var.defaults.availability_zone_rebalancing, null) | |||
| availability_zone_rebalancing = try(each.value.availability_zone_rebalancing, var.defaults.availability_zone_rebalancing, "DISABLED") | |||
|
@bryantbiggs |
bryantbiggs
pushed a commit
that referenced
this pull request
Apr 1, 2025
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to add support for availability zone rebalancing in the services.
(This PR is a rework of the following pull request : #263)
References
Motivation and Context
Fixes : #262
Breaking Changes
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull request