-
-
Notifications
You must be signed in to change notification settings - Fork 594
feat: Add support for availability zone rebalancing (#262) #269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
main.tf
Outdated
@@ -59,6 +59,7 @@ module "service" { | |||
# Service | |||
ignore_task_definition_changes = try(each.value.ignore_task_definition_changes, false) | |||
alarms = try(each.value.alarms, {}) | |||
availability_zone_rebalancing = try(each.value.availability_zone_rebalancing, "DISABLED") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
availability_zone_rebalancing = try(each.value.availability_zone_rebalancing, "DISABLED") | |
availability_zone_rebalancing = try(each.value.availability_zone_rebalancing, null) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I'll fix.
modules/service/variables.tf
Outdated
@@ -39,7 +39,7 @@ variable "alarms" { | |||
variable "availability_zone_rebalancing" { | |||
description = " ECS automatically redistributes tasks within a service across Availability Zones (AZs) to mitigate the risk of impaired application availability due to underlying infrastructure failures and task lifecycle activities. The valid values are `ENABLED` and `DISABLED`. Defaults to `DISABLED`" | |||
type = string | |||
default = null | |||
default = "DISABLED" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
revert, should be null
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK
wrappers/service/main.tf
Outdated
@@ -28,7 +28,7 @@ module "wrapper" { | |||
} | |||
}) | |||
autoscaling_scheduled_actions = try(each.value.autoscaling_scheduled_actions, var.defaults.autoscaling_scheduled_actions, null) | |||
availability_zone_rebalancing = try(each.value.availability_zone_rebalancing, var.defaults.availability_zone_rebalancing, null) | |||
availability_zone_rebalancing = try(each.value.availability_zone_rebalancing, var.defaults.availability_zone_rebalancing, "DISABLED") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
revert
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK
@bryantbiggs |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Description
This PR aims to add support for availability zone rebalancing in the services.
(This PR is a rework of the following pull request : #263)
References
Motivation and Context
Fixes : #262
Breaking Changes
How Has This Been Tested?
examples/*
to demonstrate and validate my change(s)examples/*
projectspre-commit run -a
on my pull request