Skip to content

fix: Add missing timeout to service module #272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

ponceps
Copy link

@ponceps ponceps commented Apr 1, 2025

Description

Added a new dynamic "timeout" block that supports two timeout-related configurations in modules/service/main.tf:

  • idle_timeout_seconds: For setting the amount of time in seconds a connection will stay active while idle.
  • per_request_timeout_seconds: For setting the amount of time in seconds for the upstream to respond with a complete response per request.

Motivation and Context

It was not possible to set timeout ECS Service Connect configuration.

Breaking Changes

No

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@bryantbiggs
Copy link
Member

already included in #217

@bryantbiggs bryantbiggs closed this Apr 1, 2025
@ponceps
Copy link
Author

ponceps commented Apr 1, 2025

@bryantbiggs since this is not a breaking change, why not include it in the 5.X release? it doesn’t seem necessary to postpone it until 6.X.

@bryantbiggs
Copy link
Member

it is a breaking change, it requires a min provider version of 5.37 and this module still currently uses 4.x hashicorp/terraform-provider-aws#35684

Copy link

github-actions bot commented May 2, 2025

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants