Skip to content

feat: Added managed storage KMS configuration #274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

hp197
Copy link

@hp197 hp197 commented Apr 4, 2025

Description

The changes primarily focus on adding support for managed storage configuration and updating the required AWS provider version.

Managed Storage Configuration:

  • Added a dynamic block for managed_storage_configuration in the aws_ecs_cluster resource to handle optional managed storage settings, including kms_key_id and fargate_ephemeral_storage_kms_key_id.

Provider Version Update:

  • Updated the required version of the AWS provider from >= 4.66.1 to >= 5.59.0 to ensure compatibility with empheral storage configuration.

Fixes issue #258

@hp197
Copy link
Author

hp197 commented Apr 4, 2025

Yes yes, I do know about #217, but it would be nice to have this before the major module upgrade.

@ceditpro
Copy link

Should be interesting to merge this PR who add the kms feature encryption for the storage

@bryantbiggs
Copy link
Member

managed_storage_configuration is only available starting on v5.59.0 and this module only supports up to v4.x which means this has to go in with or after #258

Copy link

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

@github-actions github-actions bot added the stale label May 18, 2025
Copy link

This PR was automatically closed because of stale in 10 days

@github-actions github-actions bot closed this May 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants