Skip to content

feat: Allow Glue Schema registry data format to be configurable #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 5, 2024
Merged

feat: Allow Glue Schema registry data format to be configurable #32

merged 1 commit into from
Aug 5, 2024

Conversation

bryantbiggs
Copy link
Member

Description

  • Allow Glue Schema registry data format to be configurable

Motivation and Context

Breaking Changes

  • No

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@rcfja
Copy link

rcfja commented Aug 5, 2024

Suggestion : update the example also https://github.com/terraform-aws-modules/terraform-aws-msk-kafka-cluster/blob/master/examples/complete/main.tf#L105

@bryantbiggs
Copy link
Member Author

why do we need to update the example? this is just an enum value

@rcfja
Copy link

rcfja commented Aug 5, 2024 •
edited
Loading

You don't need to. Might be a nice idea to let people know this data_format config is available.

@bryantbiggs
Copy link
Member Author

You don't need to. Might be a nice idea to let people know this data_format config is available.

Perhaps, but this is the first time this has come up and I don't want to make a mess of the examples. Its supported now though!

@bryantbiggs bryantbiggs merged commit 3f4806e into terraform-aws-modules:master Aug 5, 2024
10 checks passed
@bryantbiggs bryantbiggs deleted the feat/schema-data-format branch August 5, 2024 18:38
antonbabenko pushed a commit that referenced this pull request Aug 5, 2024
@semantic-release-bot
chore(release): version 2.7.0 [skip ci]
c89d85b 
## [2.7.0](v2.6.0...v2.7.0) (2024-08-05)

### Features

* Allow Glue Schema registry data format to be configurable ([#32](#32)) ([3f4806e](3f4806e))
@antonbabenko
Copy link
Member

This PR is included in version 2.7.0 🎉

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 5, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@antonbabenko antonbabenko antonbabenko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow change in schema data format
3 participants
@bryantbiggs @rcfja @antonbabenko