-
-
Notifications
You must be signed in to change notification settings - Fork 65
feat: Add cluster name to outputs #45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add cluster name to outputs #45
Conversation
sometimes it's usefull to have this value as output, for instance, when using terragrunt and use this module as dependency of another module
that won't do what you think it does - you would need to take an implicit dependency on the cluster ARN in this case https://github.com/hashicorp/terraform-provider-aws/blob/f75b604ed2ccc1618be162393b623de3f232bb57/internal/service/kafka/cluster.go#L597 but we can output the name - see note on change though to get generated name |
This PR has been automatically marked as stale because it has been open 30 days |
Co-authored-by: Bryant Biggs <[email protected]>
hey @bryantbiggs , thanks for you review! You're absolutely right - we should use the attr from the resource instead of this hack that I initially committed. I applied your suggested change - could you please re-review the PR? |
## [2.11.0](v2.10.0...v2.11.0) (2025-01-06) ### Features * Add cluster name to outputs ([#45](#45)) ([c2ac138](c2ac138))
This PR is included in version 2.11.0 🎉 |
@antonbabenko can you please publish 2.11.0 to Terraform registry? |
@mattiamatrix Fixed |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Description
Sometimes it's useful to have this value as output, for instance, when using terragrunt and use this module as dependency of another module.
Motivation and Context
Just adds the output with cluster name. Useful when using module as dependency of another module.
Breaking Changes
No breaking changes
How Has This Been Tested?
examples/*
to demonstrate and validate my change(s)examples/*
projectspre-commit run -a
on my pull request