Skip to content

feat: Add cluster name to outputs #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

wladyslawczyzewski
Copy link
Contributor

@wladyslawczyzewski wladyslawczyzewski commented Nov 28, 2024

Description

Sometimes it's useful to have this value as output, for instance, when using terragrunt and use this module as dependency of another module.

Motivation and Context

Just adds the output with cluster name. Useful when using module as dependency of another module.

Breaking Changes

No breaking changes

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request
  • I have tested and validated these changes using production cluster :)

sometimes it's usefull to have this value as output, for instance, when using terragrunt and use this module as dependency of another module
@wladyslawczyzewski wladyslawczyzewski changed the title add cluster name to outputs chore: add cluster name to outputs Nov 28, 2024
@wladyslawczyzewski wladyslawczyzewski changed the title chore: add cluster name to outputs chore: Add cluster name to outputs Nov 28, 2024
@bryantbiggs
Copy link
Member

that won't do what you think it does - you would need to take an implicit dependency on the cluster ARN in this case https://github.com/hashicorp/terraform-provider-aws/blob/f75b604ed2ccc1618be162393b623de3f232bb57/internal/service/kafka/cluster.go#L597

but we can output the name - see note on change though to get generated name

Copy link

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

@github-actions github-actions bot added the stale label Dec 30, 2024
@wladyslawczyzewski
Copy link
Contributor Author

hey @bryantbiggs , thanks for you review! You're absolutely right - we should use the attr from the resource instead of this hack that I initially committed.

I applied your suggested change - could you please re-review the PR?

@github-actions github-actions bot removed the stale label Jan 5, 2025
@bryantbiggs bryantbiggs changed the title chore: Add cluster name to outputs feat: Add cluster name to outputs Jan 6, 2025
@bryantbiggs bryantbiggs merged commit c2ac138 into terraform-aws-modules:master Jan 6, 2025
11 checks passed
antonbabenko pushed a commit that referenced this pull request Jan 6, 2025
## [2.11.0](v2.10.0...v2.11.0) (2025-01-06)

### Features

* Add cluster name to outputs ([#45](#45)) ([c2ac138](c2ac138))
@antonbabenko
Copy link
Member

This PR is included in version 2.11.0 🎉

@mattiamatrix
Copy link

@antonbabenko can you please publish 2.11.0 to Terraform registry?

@antonbabenko
Copy link
Member

@mattiamatrix Fixed

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants