fix: Allow IPv6 IPAM pool without requiring IPv4 IPAM#1293
Open
owen-method wants to merge 1 commit intoterraform-aws-modules:masterfrom
Open
fix: Allow IPv6 IPAM pool without requiring IPv4 IPAM#1293owen-method wants to merge 1 commit intoterraform-aws-modules:masterfrom
owen-method wants to merge 1 commit intoterraform-aws-modules:masterfrom
Conversation
owen-method
changed the title
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Allow IPv6 IPAM pool to be used without requiring an IPv4 IPAM pool.
Motivation and Context
When
use_ipam_pool = truebut only an IPv6 IPAM pool is configured (noipv4_ipam_pool_id), two bugs occurred:cidr_blockwas set to null, breaking IPv4 CIDR assignmentassign_generated_ipv6_cidr_blockwas omitted, breaking AWS-generated IPv6 CIDR assignmentFixes #1282
Breaking Changes
None. This is a bug fix that only affects configurations using
use_ipam_pool = truewith IPv6 IPAM but no IPv4 IPAM pool, a combination that was previously broken.How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull requestThe
examples/ipam/example already has IPv6 IPAM infrastructure present but commented out due to BYOIP requirements. The fix applies to the logic in main.tf and was manually validated in a live environment.