Skip to content

feat: allow set disk size & type on vm runners#235

Merged
apeabody merged 2 commits into
terraform-google-modules:mainfrom
davidmontoyago:feat-set-runner-disk-size
Nov 17, 2025
Merged

feat: allow set disk size & type on vm runners#235
apeabody merged 2 commits into
terraform-google-modules:mainfrom
davidmontoyago:feat-set-runner-disk-size

Conversation

@davidmontoyago

Copy link
Copy Markdown
Contributor

Allow setting the disk size on modules/gh-runner-mig-container-vm and modules/gh-runner-mig-vm for thin provisioning

@davidmontoyago davidmontoyago requested a review from a team as a code owner October 31, 2025 17:17
@google-cla

google-cla Bot commented Oct 31, 2025

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@davidmontoyago davidmontoyago force-pushed the feat-set-runner-disk-size branch from befdf1b to 346e77f Compare November 17, 2025 18:42
@davidmontoyago

Copy link
Copy Markdown
Contributor Author

Hi @apeabody @bharathkkb, can I get a review? the current 100gb size is too generous causing quotas to exceed when launching a handful of runners.

@apeabody

Copy link
Copy Markdown
Contributor

/gcbrun

@apeabody

Copy link
Copy Markdown
Contributor

/gemini review

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the ability to configure the disk size and type for VM runners in both gh-runner-mig-container-vm and gh-runner-mig-vm modules. The changes are well-implemented, exposing disk_size_gb and disk_type as variables and updating the documentation accordingly. My review includes suggestions to add validation blocks for these new variables to improve the robustness of the modules by ensuring that only valid values are provided during configuration.

Comment thread modules/gh-runner-mig-container-vm/variables.tf
Comment thread modules/gh-runner-mig-container-vm/variables.tf
Comment thread modules/gh-runner-mig-vm/variables.tf
Comment thread modules/gh-runner-mig-vm/variables.tf

@apeabody apeabody left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @davidmontoyago!

@apeabody apeabody merged commit 4433035 into terraform-google-modules:main Nov 17, 2025
4 checks passed
alinetskyi pushed a commit to CoreumFoundation/terraform-google-github-actions-runners that referenced this pull request Dec 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants