feat: allow set disk size & type on vm runners#235
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
befdf1b to
346e77f
Compare
|
Hi @apeabody @bharathkkb, can I get a review? the current 100gb size is too generous causing quotas to exceed when launching a handful of runners. |
|
/gcbrun |
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request introduces the ability to configure the disk size and type for VM runners in both gh-runner-mig-container-vm and gh-runner-mig-vm modules. The changes are well-implemented, exposing disk_size_gb and disk_type as variables and updating the documentation accordingly. My review includes suggestions to add validation blocks for these new variables to improve the robustness of the modules by ensuring that only valid values are provided during configuration.
apeabody
left a comment
There was a problem hiding this comment.
Thanks for the contribution @davidmontoyago!
Allow setting the disk size on
modules/gh-runner-mig-container-vmandmodules/gh-runner-mig-vmfor thin provisioning