-
Notifications
You must be signed in to change notification settings - Fork 1.3k
fix(TPG>=7.10)!: bump min google provider to 7.10 for network_tier_config support #2527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(TPG>=7.10)!: bump min google provider to 7.10 for network_tier_config support #2527
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Summary of ChangesHello @watsonjm, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a compatibility issue where the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
The pull request effectively addresses the stated problem by bumping the minimum required versions of the hashicorp/google and hashicorp/google-beta providers to 7.10.0. This change is necessary to support the network_tier_config block in google_container_cluster resources, resolving the Unsupported block type error for users on older provider versions. All versions.tf and metadata.yaml files across the main module and its sub-modules have been consistently updated. The changes are straightforward and correctly implement the intended fix. No further issues were found.
|
/gcbrun |
apeabody
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @watsonjm!
Description
This PR bumps the minimum required version of the hashicorp/google and hashicorp/google-beta providers to 7.10.0.
Fixes #2523
Reason
The network_tier_config block was added to the google_container_cluster resource in the Google provider version 7.10.0 (reference).
The current module code (v43.0.0+) utilizes this block in cluster.tf. However, the provider version constraint was previously set to >= 7.0.0. Users running provider versions between 7.0.0 and 7.9.0 encounter the following error:
Changes
Updated
autogen/versions.tf.tmplto requiregoogleandgoogle-beta >= 7.10.0.Ran
make buildto regenerate all moduleversions.tffiles.