Skip to content

feat: add currency_code variable to budget module#1024

Open
lucascicco wants to merge 1 commit intoterraform-google-modules:mainfrom
lucascicco:main
Open

feat: add currency_code variable to budget module#1024
lucascicco wants to merge 1 commit intoterraform-google-modules:mainfrom
lucascicco:main

Conversation

@lucascicco
Copy link

Hi all,

This PR solves this issue: #1023

Thanks.

@lucascicco lucascicco requested review from a team and imrannayer as code owners December 16, 2025 12:46
@gemini-code-assist
Copy link

Summary of Changes

Hello @lucascicco, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses issue #1023 by enhancing the budget module to support explicit currency specification for budget amounts. It introduces a new currency_code variable, defaulting to USD, which is then used in the google_billing_budget resource. This change provides greater flexibility for users managing budgets in different currencies and includes relevant documentation and metadata updates.

Highlights

  • New currency_code variable: Introduced a new currency_code variable in the budget module, allowing users to specify the currency for budget amounts, defaulting to USD. This variable is integrated into the google_billing_budget resource.
  • Terraform Provider Version Update: The hashicorp/google provider version constraint has been updated in metadata.yaml from >= 4.28, < 7 to >= 4.28, < 8.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a currency_code variable to the budget module, which is a great addition. The changes are consistently applied across the module's documentation, variable definitions, and resource configuration.

I have one important suggestion to ensure the module's stability for all users:

  • The Google provider version constraint needs to be updated. The new currency_code feature requires a newer version of the provider than what is currently specified as the minimum. I've left a specific comment on this.

Additionally, it would be beneficial to update the integration tests to validate the new currency_code functionality. This will help catch any future regressions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant